Skip to content

fix(Shuffle): clip wrapper is shorter than the glyph, cutting descenders #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Baltsar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Shuffle): clip wrapper is shorter than the glyph, cutting descenders #1051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/content/TextAnimations/Shuffle/Shuffle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@
}

.shuffle-char {
line-height: 1;
/* `normal` resolves to the font's own ascent + descent. The clip wrapper is
sized from this box, so a fixed 1 makes the mask shorter than the glyph
and clips descenders on every face that has them. Line spacing is still
controlled by .shuffle-parent. */
line-height: normal;
display: inline-block;
text-align: center;
}
5 changes: 4 additions & 1 deletion src/tailwind/TextAnimations/Shuffle/Shuffle.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ const Shuffle = ({

splitRef.current = new GSAPSplitText(el, {
type: 'chars',
charsClass: 'shuffle-char',
// `leading-normal` overrides the parent's `leading-none` on the char
// itself: the clip wrapper is sized from this box, and a line-height
// of 1 makes the mask shorter than the glyph, clipping descenders.
charsClass: 'shuffle-char leading-normal',
wordsClass: 'shuffle-word',
linesClass: 'shuffle-line',
smartWrap: true,
Expand Down
6 changes: 5 additions & 1 deletion src/ts-default/TextAnimations/Shuffle/Shuffle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@
}

.shuffle-char {
line-height: 1;
/* `normal` resolves to the font's own ascent + descent. The clip wrapper is
sized from this box, so a fixed 1 makes the mask shorter than the glyph
and clips descenders on every face that has them. Line spacing is still
controlled by .shuffle-parent. */
line-height: normal;
display: inline-block;
text-align: center;
}
5 changes: 4 additions & 1 deletion src/ts-tailwind/TextAnimations/Shuffle/Shuffle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,10 @@ const Shuffle: React.FC<ShuffleProps> = ({

splitRef.current = new GSAPSplitText(el, {
type: 'chars',
charsClass: 'shuffle-char',
// `leading-normal` overrides the parent's `leading-none` on the char
// itself: the clip wrapper is sized from this box, and a line-height
// of 1 makes the mask shorter than the glyph, clipping descenders.
charsClass: 'shuffle-char leading-normal',
wordsClass: 'shuffle-word',
linesClass: 'shuffle-line',
smartWrap: true,
Expand Down