parser: accept only RFC 8259 whitespace between tokens - #1076
Open
AetherAI3 wants to merge 1 commit into
Open
Conversation
Closes DaveGamble#1074. buffer_skip_whitespace treated every byte <= 32 as whitespace, so NUL (0x00), 0x01, 0x0b, 0x0c, 0x1f, and every other C0 control byte were silently skipped between tokens. RFC 8259 whitespace is only 0x20, 0x09, 0x0a, 0x0d. Before: cJSON_ParseWithLengthOpts("[\\x0b1]", 5, NULL, 1) -> [1] cJSON_ParseWithLengthOpts("[\\x011]", 5, NULL, 1) -> [1] cJSON_ParseWithLengthOpts("\\x00null", 6, NULL, 1) -> null After: all three return NULL. Existing whitespace inputs (space, tab, newline, CR, mixed) still parse identically. Reported by @nassersala. In-tree ctest -j4 -> 19/19 pass on the patched build. Signed-off-by: Brandon Barrante <aetherai@aethersystems.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1074.
buffer_skip_whitespace treated every byte <= 32 as whitespace, so NUL (0x00), 0x01, 0x0b, 0x0c, 0x1f, and every other C0 control byte were silently skipped between tokens. RFC 8259 whitespace is only 0x20, 0x09, 0x0a, 0x0d.
Before:
cJSON_ParseWithLengthOpts("[\x0b1]", 5, NULL, 1) -> [1]
cJSON_ParseWithLengthOpts("[\x011]", 5, NULL, 1) -> [1]
cJSON_ParseWithLengthOpts("\x00null", 6, NULL, 1) -> null
After: all three return NULL. Existing whitespace inputs (space, tab, newline, CR, mixed) still parse identically.
Reported by @nassersala. In-tree ctest -j4 -> 19/19 pass on the patched build.