Document local PostgreSQL service - #8
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The README’s PostgreSQL connection details and volume naming are slightly misleading/incomplete relative to compose.yaml.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Updates the project documentation to describe the included Docker Compose PostgreSQL service while clarifying that the Spring Boot application continues to use H2 for now.
Changes:
- Expanded the documented tech stack and “What this demonstrates” sections to include PostgreSQL + Docker Compose.
- Added local commands to start/stop the PostgreSQL service via
compose.yaml. - Reworked database notes and limitations to clearly state PostgreSQL is provisioned but not yet wired into the app.
File summaries
| File | Description |
|---|---|
| README.md | Documents local PostgreSQL (Docker Compose) alongside the current H2-based runtime/testing setup. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| User: sa | ||
| Password: <empty> | ||
| ``` | ||
| PostgreSQL data is stored in the named Docker volume `spring-boot-process-api-basics_processdb-data`. The application will be connected to this service in a later step using dedicated Spring profiles. |
Comment on lines
+307
to
+309
| Database: processdb | ||
| User: processapp | ||
| Port: 5432 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Scope
This pull request only updates the README. It does not change the application configuration or connect Spring Boot to PostgreSQL.
Validation
compose.yaml