skip test for APPSEC-61861#7245
Conversation
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: a0475d0 | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0475d05ff
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/appsec/iast/sink/test_unvalidated_redirect.py::TestUnvalidatedHeader: # Easy win for django-poc, django-py3.13, fastapi, flask-poc, python3.12, uds-flask, uwsgi-poc and version 4.6.4 | ||
| - weblog_declaration: | ||
| "*": v4.7.0-rc1 (implemented in v3.9.0.dev, but there was the APPSEC-57817 and APPSEC-61861 bugs) | ||
| "*": flaky (APPSEC-61861) # v4.7.0-rc1 (implemented in v3.9.0.dev, but there was the APPSEC-57817 and APPSEC-61861 bugs) |
There was a problem hiding this comment.
Keep the version gate when marking the class flaky
This class-level wildcard now applies a flaky skip to every TestUnvalidatedHeader item, and manifest matches are cumulative/prefix-based, so the more specific TestUnvalidatedHeader::test_secure entry below cannot re-enable that method at v4.12.0-rc1. In Python runs where test_secure should be active, it will still be skipped as flaky (APPSEC-61861) for all weblogs/versions; keep the version constraint on the flaky declaration or target only the failing method so the secure test can run once its own gate is satisfied.
Useful? React with 👍 / 👎.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present