Skip to content

skip test for APPSEC-61861#7245

Merged
cbeauchesne merged 2 commits into
mainfrom
cbeauchesne/APPSEC-61861
Jul 1, 2026
Merged

skip test for APPSEC-61861#7245
cbeauchesne merged 2 commits into
mainfrom
cbeauchesne/APPSEC-61861

Conversation

@cbeauchesne

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 1, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a0475d0 | Docs | Datadog PR Page | Give us feedback!

@cbeauchesne cbeauchesne marked this pull request as ready for review July 1, 2026 16:56
@cbeauchesne cbeauchesne requested review from a team as code owners July 1, 2026 16:56
@cbeauchesne cbeauchesne requested review from ZStriker19 and gnufede and removed request for a team July 1, 2026 16:56
@cbeauchesne cbeauchesne merged commit 8abbb15 into main Jul 1, 2026
47 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/APPSEC-61861 branch July 1, 2026 16:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0475d05ff

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread manifests/python.yml
tests/appsec/iast/sink/test_unvalidated_redirect.py::TestUnvalidatedHeader: # Easy win for django-poc, django-py3.13, fastapi, flask-poc, python3.12, uds-flask, uwsgi-poc and version 4.6.4
- weblog_declaration:
"*": v4.7.0-rc1 (implemented in v3.9.0.dev, but there was the APPSEC-57817 and APPSEC-61861 bugs)
"*": flaky (APPSEC-61861) # v4.7.0-rc1 (implemented in v3.9.0.dev, but there was the APPSEC-57817 and APPSEC-61861 bugs)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the version gate when marking the class flaky

This class-level wildcard now applies a flaky skip to every TestUnvalidatedHeader item, and manifest matches are cumulative/prefix-based, so the more specific TestUnvalidatedHeader::test_secure entry below cannot re-enable that method at v4.12.0-rc1. In Python runs where test_secure should be active, it will still be skipped as flaky (APPSEC-61861) for all weblogs/versions; keep the version constraint on the flaky declaration or target only the failing method so the secure test can run once its own gate is satisfied.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant