Skip to content

Adds TRACE_STATS_COMPUTATION_CLIENT_DROP_P0S_FALSE in system-test CI#7244

Merged
cbeauchesne merged 4 commits into
mainfrom
cbeauchesne/TRACE_STATS_COMPUTATION_CLIENT_DROP_P0S_FALSE
Jul 1, 2026
Merged

Adds TRACE_STATS_COMPUTATION_CLIENT_DROP_P0S_FALSE in system-test CI#7244
cbeauchesne merged 4 commits into
mainfrom
cbeauchesne/TRACE_STATS_COMPUTATION_CLIENT_DROP_P0S_FALSE

Conversation

@cbeauchesne

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.github/workflows/run-end-to-end.yml                                    @DataDog/system-tests-core
manifests/cpp_httpd.yml                                                 @DataDog/dd-trace-cpp
manifests/cpp_nginx.yml                                                 @DataDog/dd-trace-cpp

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 1, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 5 Pipeline jobs failed

Testing the test | System Tests (php, prod) / End-to-end #2 / laravel11x 2   View in Datadog   GitHub Actions

🧪 1 Test failed

tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Endpoints.test_sampling_delay[laravel11x] from system_tests_suite   View in Datadog
assert False
 +  where False = all(<generator object Test_API_Security_Sampling_Different_Endpoints.test_sampling_delay.<locals>.<genexpr> at 0x7f9400700e40>)

self = <tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Endpoints object at 0x7f941bf8e810>

    def test_sampling_delay(self):
        assert self.request1.status_code == 200
        schema1 = get_schema(self.request1, "req.headers")
        assert schema1 is not None
    
...

Testing the test | System Tests (python, dev) / End-to-end #1 / flask-poc 1   View in Datadog   GitHub Actions

🧪 2 Tests failed

tests.appsec.iast.sink.test_unvalidated_redirect.TestUnvalidatedHeader.test_secure[flask-poc] from system_tests_suite   View in Datadog
ValueError: Unexpected vulnerability reported: UNVALIDATED_REDIRECT

self = <tests.appsec.iast.sink.test_unvalidated_redirect.TestUnvalidatedHeader object at 0x7fe0a8aa65a0>

    def test_secure(self):
>       return super().test_secure()

tests/appsec/iast/sink/test_unvalidated_redirect.py:62: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/appsec/iast/utils.py:186: in test_secure
...
tests.appsec.iast.sink.test_unvalidated_redirect.TestUnvalidatedRedirect.test_secure[flask-poc] from system_tests_suite   View in Datadog
ValueError: Unexpected vulnerability reported: UNVALIDATED_REDIRECT

self = <tests.appsec.iast.sink.test_unvalidated_redirect.TestUnvalidatedRedirect object at 0x7fe0a8aa6ae0>

    def test_secure(self):
>       super().test_secure()

tests/appsec/iast/sink/test_unvalidated_redirect.py:47: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/appsec/iast/utils.py:186: in test_secure
...

Testing the test | System Tests (java, prod) / End-to-end #2 / akka-http 2   View in Datadog   GitHub Actions

🧪 2 Tests failed

tests.appsec.test_blocking_addresses.Test_Blocking_request_body_filenames.test_non_blocking[akka-http] from system_tests_suite   View in Datadog
ValueError: No appsec event validate this condition

self = <tests.appsec.test_blocking_addresses.Test_Blocking_request_body_filenames object at 0x7efedc909130>

    def test_non_blocking(self):
        """Does not block on server.request.body.filenames when filename is safe"""
>       self.test_blocking()

tests/appsec/test_blocking_addresses.py:615: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
...
❄️ Known flaky: tests.appsec.test_blocking_addresses.Test_Blocking_request_body_multipart.test_blocking[akka-http] from system_tests_suite   View in Datadog
ValueError: No appsec event validate this condition

self = <tests.appsec.test_blocking_addresses.Test_Blocking_request_body_multipart object at 0x7efedc908f20>

    def test_blocking(self):
        """Can block on server.request.body (multipart/form-data variant)"""
    
>       interfaces.library.assert_waf_attack(self.rbmp_req, rule="tst-037-004")

tests/appsec/test_blocking_addresses.py:591: 
...

Not introduced in this PR.

View all 5 failed jobs.

🧪 1 Test failed in 1 job

Testing the test | main   GitHub Actions

tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Endpoints.test_sampling_delay[laravel11x] from system_tests_suite   View in Datadog
assert False
 +  where False = all(<generator object Test_API_Security_Sampling_Different_Endpoints.test_sampling_delay.<locals>.<genexpr> at 0x7fa9a9bd1b60>)

self = <tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Endpoints object at 0x7fa9d13abb30>

    def test_sampling_delay(self):
        assert self.request1.status_code == 200
        schema1 = get_schema(self.request1, "req.headers")
        assert schema1 is not None
    
...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0fd369b | Docs | Datadog PR Page | Give us feedback!

@cbeauchesne cbeauchesne marked this pull request as ready for review July 1, 2026 16:48
@cbeauchesne cbeauchesne requested review from a team as code owners July 1, 2026 16:48
@cbeauchesne cbeauchesne requested review from cataphract and removed request for a team July 1, 2026 16:48
@cbeauchesne cbeauchesne merged commit fe772fd into main Jul 1, 2026
695 of 701 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/TRACE_STATS_COMPUTATION_CLIENT_DROP_P0S_FALSE branch July 1, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants