Enable span links parametric tests for cpp [cpp@milan.garnier/span-links-support]#7238
Enable span links parametric tests for cpp [cpp@milan.garnier/span-links-support]#7238MilanGarnier wants to merge 4 commits into
Conversation
Enable parametric span links tests for C++ tracer once dd-trace-cpp/milan.garnier/span-links-support lands (>2.1.2). Two tests remain missing_feature: v0.5 not implemented, auto.drop not supported. Binaries point to milan.garnier/span-links-support branch (DataDog/dd-trace-cpp#330) for CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b874d214b3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| https://github.com/DataDog/dd-trace-cpp.git@milan.garnier/span-links-support No newline at end of file | |||
There was a problem hiding this comment.
When this change is merged, every C++ parametric build that sees binaries/cpp-load-from-git will clone milan.garnier/span-links-support instead of the default tracer release/main path (utils/build/docker/cpp/parametric/install_ddtrace.sh reads this file before falling back). That makes all future C++ runs depend on a personal feature branch and can silently test the wrong tracer, or fail once the branch disappears; this override should stay as an untracked/local CI artifact rather than being committed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I will remove it once CI has passed on the branch once.
|
MilanGarnier
changed the title
1 participant
Summary
>2.1.2(feature not yet in any release)binaries/cpp-load-from-gitpoints tomilan.garnier/span-links-supportbranch so CI runs against the correct branch (TO remove when featuremissing_feature:test_span_started_with_link_v05: v0.5 encoding not implementedtest_span_link_propagated_sampling_decisions: auto.drop not supportedTest plan
TEST_LIBRARY=cpp ./run.sh PARAMETRIC -k "span_link"locally against the branch — 4 passed, 2 xfailed (expected), 2 skippedmilan.garnier/span-links-supportviabinaries/cpp-load-from-git🤖 Generated with Claude Code