Update OTLP trace metrics parametric tests to align with JS and .NET implementations#7217
Merged
Conversation
Activate tests/parametric/test_otlp_trace_metrics.py for dotnet (replacing the whole-file missing_feature skip). The span-duration check (fr01_5) and the client-computed-stats checks (fr02_3, fr15) now key off the real span flush, and the unimplemented fr06_6 (rpc.method) case is removed. host.name (fr06_10) and process tags (fr08_8) remain skipped as missing_feature until the tracer emits them. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 958fe9be73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 5062729 | Docs | Datadog PR Page | Give us feedback! |
mabdinur
commented
Jun 25, 2026
- fr01_5 now polls the full flush window and fails only if the span-duration metric ever appears, so an unrelated OTLP metric (e.g. runtime metrics) can no longer mask a regression. - Fix YAML indentation of the test_otlp_trace_metrics.py missing_feature entries in manifests/dotnet.yml. test_fr06_6_rpc_method is intentionally left removed (no longer in the RFC). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Blocked by: DataDog/dd-trace-dotnet#8826 |
mabdinur
changed the title
mhlidd
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Activates
tests/parametric/test_otlp_trace_metrics.pyfor the .NET tracer, replacing the whole-filemissing_featureskip inmanifests/dotnet.ymlwith targeted per-test skips for the two features the tracer does not emit yet.munir/otlp-span-metrics(OTLP trace metrics over HTTP/JSON): 43 passed / 2 skipped-as-missing_feature.fr01_5now asserts the span-duration metric specifically (other OTLP metrics such as runtime metrics may legitimately be present).fr02_3andfr15now key off the real span flush (X-Datadog-Trace-Count > 0) rather than empty keep-alive payloads, via a new_span_carrying_trace_requestshelper.fr06_6(rpc.method) case (feature not planned for this iteration).Manifest skips (dotnet)
Test_FR06_Otel_Resource_Attributes::test_fr06_10_hostname—host.namenot yet reported on the OTLP trace metrics resource.Test_FR08_Datadog_Attributes::test_fr08_8_process_tags— process tags not yet emitted on the OTLP trace metrics resource.Test plan
TEST_LIBRARY=dotnet ./run.sh PARAMETRIC -k test_otlp_trace_metricsis green (the two skips above are expected)../format.shpasses.Made with Cursor