Use weblog infra for haproxy and envoy integrations#7179
Conversation
|
|
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78bf716e81
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| result["dd_tags[systest.suite.context.library.version]"] = self.library.version | ||
| result["dd_tags[systest.suite.context.weblog_variant]"] = self.weblog_variant | ||
| result["dd_tags[systest.suite.context.appsec_rules_file]"] = self.weblog_container.appsec_rules_file or "" | ||
| result["dd_tags[systest.suite.context.appsec_rules_file]"] = self.weblog_infra.appsec_rules_file or "" |
There was a problem hiding this comment.
Preserve appsec_rules_file on EndToEndScenario
When a scenario does not use custom rules, tests rely on context.appsec_rules_file resolving to None; after this change EndToEndScenario no longer exposes that property, so context._get_scenario_property falls back to "", making existing is not None decorators in tests/appsec/test_runtime_activation.py and tests/remote_config/test_remote_configuration.py apply to every end-to-end scenario. This line still only emits the value as a JUnit tag, so please also restore an appsec_rules_file property on the scenario that delegates to self.weblog_infra.appsec_rules_file.
Useful? React with 👍 / 👎.
| if library == "golang": | ||
| result.append(Weblog(name="envoy", require_build=False, artifact_name=binaries_artifact)) | ||
| result.append(Weblog(name="haproxy", require_build=False, artifact_name=binaries_artifact)) |
There was a problem hiding this comment.
Honor weblog filters for proxy weblogs
When weblogs_filter is set, the Dockerfile-backed Golang weblogs are filtered above, but these new proxy weblogs are appended unconditionally. A filtered run such as a manual Golang job for only gin will now also schedule envoy and haproxy jobs even though they were not requested; apply the same filter before appending these non-Dockerfile weblogs.
Useful? React with 👍 / 👎.
Motivation
Will replace #6464
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present