Add trace filter tests [APMSP-2763] by Eldolfin · Pull Request #6952 · DataDog/system-tests

Eldolfin · 2026-05-15T17:26:44Z

APMSP-2763
APMSP-3048

Motivation

Changes

Add system-tests coverage for the CSS V1.2 spec trace filters (filter_tags, filter_tags_regex, ignore_resources).

TODO

add resources/tags normalization test

Workflow

⚠️ Create your PR as draft ⚠️
Work on you PR until the CI passes
Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner.
- Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
A docker base image is modified?
- the relevant build-XXX-image label is present
A scenario is added, removed or renamed?
- Get a review from R&P team

APMSP-2763

github-actions · 2026-05-15T17:27:16Z

CODEOWNERS have been resolved as:

tests/stats/test_trace_filters.py                                       @DataDog/system-tests-core
.github/workflows/run-end-to-end.yml                                    @DataDog/system-tests-core
manifests/cpp.yml                                                       @DataDog/dd-trace-cpp
manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
manifests/rust.yml                                                      @DataDog/apm-rust
tests/test_the_test/scenarios.json                                      @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/_context/_scenarios/endtoend.py                                   @DataDog/system-tests-core
utils/_context/containers.py                                            @DataDog/system-tests-core
utils/proxy/mocked_response.py                                          @DataDog/system-tests-core

… scheme (#2008) These fields were renamed in version 7.79.0 of the agent for consistency. # What does this PR do? Allow both PascalCase and the newer snake_case format for these fields. # Motivation The trace exporter was crashing in a confusing way in new system tests I wrote for another feature: DataDog/system-tests#6952. I had an older agent. # Additional Notes Anything else we should know when reviewing? # How to test the change? Describe here in detail how the change can be validated. Co-authored-by: oscar.ledauphin <oscar.ledauphin@datadoghq.com>

# What does this PR do? Implements the CSS trace-level filtering mechanism, that is applied before stats computation. # Motivation It's un unmet requirement from the spec. # Additional Notes ~Please Ctrl+F `FIXME` when reviewing, I let some questions in the code that I'd like answers for before merging~ ## TODO: - [x] unit tests - [x] system-tests DataDog/system-tests#6952 - [x] normalization before filtering - [x] regex keys (currently only regex values are checked) - [x] new spec or CSS spec RFC - [x] telemetry ? Count dropped traces with the reason - [x] trim spaces when parsing config - [x] Move implementation to trace-utils - [x] stop using v4 span but generic spans instead for php - [x] move arcswap to the trace exporter (remove update_conf) - [x] use test agent for snapshot tests ## Wont do - [ ] ~advanced resource normalization (sql, redis etc...).~ No other implementation does that - [ ] ~100% normalization edge cases (empty service field + non-normalized name + filter depending on that)~ Too specific edge case. Ignoring it for now - [ ] ~check on meta_struct too~ Not in the spec [APMSP-2763] [APMSP-2763]: https://datadoghq.atlassian.net/browse/APMSP-2763?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: oscar.ledauphin <oscar.ledauphin@datadoghq.com>

datadog-official · 2026-06-17T15:00:23Z

Tests

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 138 Pipeline jobs failed

Testing the test | System Tests (php, dev) / End-to-end #2 / apache-mod-7.0 2

🧪 1 Test failed

pytest.internal[apache-mod-7.0] from system_tests_suite

internal error

Traceback (most recent call last):
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/_pytest/main.py&#34;, line 268, in wrap_session
    session.exitstatus = doit(config, session) or 0
                         ^^^^^^^^^^^^^^^^^^^^^
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/_pytest/main.py&#34;, line 321, in _main
    config.hook.pytest_collection(session=session)
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/pluggy/_hooks.py&#34;, line 265, in __call__
    return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
...

Testing the test | System Tests (php, dev) / End-to-end #2 / apache-mod-7.0-zts 2

🧪 1 Test failed

pytest.internal[apache-mod-7.0-zts] from system_tests_suite

internal error

Traceback (most recent call last):
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/_pytest/main.py&#34;, line 268, in wrap_session
    session.exitstatus = doit(config, session) or 0
                         ^^^^^^^^^^^^^^^^^^^^^
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/_pytest/main.py&#34;, line 321, in _main
    config.hook.pytest_collection(session=session)
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/pluggy/_hooks.py&#34;, line 265, in __call__
    return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
...

Testing the test | System Tests (php, dev) / End-to-end #2 / apache-mod-7.1 2

🧪 1 Test failed

pytest.internal[apache-mod-7.1] from system_tests_suite

internal error

Traceback (most recent call last):
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/_pytest/main.py&#34;, line 268, in wrap_session
    session.exitstatus = doit(config, session) or 0
                         ^^^^^^^^^^^^^^^^^^^^^
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/_pytest/main.py&#34;, line 321, in _main
    config.hook.pytest_collection(session=session)
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/pluggy/_hooks.py&#34;, line 265, in __call__
    return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
...

View all 138 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 23908c8 | Docs | Datadog PR Page | Give us feedback!}

…ter-test

feat: add trace filter tests (checked on stats)

633a7a5

APMSP-2763

Eldolfin changed the title ~~feat: add trace filter tests (checked on stats)~~ feat: add trace filter tests [APMSP-2763] May 15, 2026

Eldolfin changed the title ~~feat: add trace filter tests [APMSP-2763]~~ Add trace filter tests [APMSP-2763] May 15, 2026

This was referenced May 15, 2026

CSS v1.2.0: Phase A — parametric coverage additions #6938

Merged

feat(data-pipeline)!: CSS Trace Filters DataDog/libdatadog#1985

Merged

fix: simplify tests and explain results

6c4631b

Eldolfin mentioned this pull request May 18, 2026

fix(data-pipeline): allow old PascalCase fields in obfuscation config scheme DataDog/libdatadog#2008

Merged

add manifest

c358546

Eldolfin added 7 commits June 17, 2026 17:15

Merge remote-tracking branch 'origin/main' into oscarld/add-trace-fil…

7173a8e

…ter-test

fix: bad merge

3f0500b

test: edge cases

07511e1

feat: enable for php >=1.22.0

ca48ec8

fix: format

d0de68d

Merge remote-tracking branch 'origin/main' into oscarld/add-trace-fil…

d1e0ac2

…ter-test

fix: add new scenarios to ci

23908c8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add trace filter tests [APMSP-2763]#6952

Add trace filter tests [APMSP-2763]#6952
Eldolfin wants to merge 10 commits into
mainfrom
oscarld/add-trace-filter-test

Eldolfin commented May 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 15, 2026 •

edited

Loading

Uh oh!

datadog-official Bot commented Jun 17, 2026 •

edited by datadog-prod-us1-4 Bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Eldolfin commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

TODO

Workflow

Reviewer checklist

Uh oh!

github-actions Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-official Bot commented Jun 17, 2026 • edited by datadog-prod-us1-4 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Eldolfin commented May 15, 2026 •

edited

Loading

github-actions Bot commented May 15, 2026 •

edited

Loading

datadog-official Bot commented Jun 17, 2026 •

edited by datadog-prod-us1-4 Bot

Loading