[parametric] Validate version and env tag are set on CSS payloads when non-empty#6869
Merged
Conversation
…gregationkeys_TS003 Extends TS003 to cover per-span version tags as a distinct stats aggregation key. Catches the bug introduced in dd-trace-go v2.8.0 (fixed in PR #4734) where the client-side stats concentrator ignored per-span version meta and collapsed all spans into a version="" bucket. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa00140f19
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 638d31f | Docs | Datadog PR Page | Give us feedback! |
ichinaski
approved these changes
May 7, 2026
zacharycmontoya
approved these changes
May 7, 2026
…-rc.2 Per-span version tag support in client-side stats aggregation key was fixed in dd-trace-go#4734 and released in v2.8.2-rc.2. Gate the new version dimension assertion so CI does not fail on older tracer builds. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
nccatoni
approved these changes
May 12, 2026
9 tasks
ajgajg1134
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
This test was written to catch a bug in dd-trace-go v2.8.0 (DataDog/dd-trace-go#4734) where the client-side stats concentrator ignored per-span
versionmeta tags and collapsed all spans into aversion=""bucket. The bug was introduced when/infopolling was added to dynamically activate client-side stats — the concentrator's aggregation key was initialized once at construction time from global config, never reading per-span version tags.Version is a PAYLOAD level tag so it is considered constant per tracer version so we only assert it at the payload level.
Test plan
Run the tests :)