feat(golang): add OTLP runtime metrics system tests by anna-git · Pull Request #6857 · DataDog/system-tests

anna-git · 2026-05-05T14:25:30Z

Motivation

Add system tests for the new OTel semantic-convention Go runtime metrics feature in dd-trace-go (PR #4803 — now merged to main as well as in dd-trace-go (PR #4962

When `DD_METRICS_OTEL_ENABLED=true`, dd-trace-go emits Go runtime metrics via OTLP using OTel semconv naming (`go.memory.used`, `go.goroutine.count`, etc.) instead of DD-proprietary naming (`runtime.go.*`).

Changes

`tests/test_otlp_runtime_metrics.py`: Extended `Test_OtlpRuntimeMetrics` with Go support:
- Removed `missing_feature` marker for Go from the manifest
- Added `go.memory.used` `present_values` constraint (`go.memory.type`: `other`, `stack`) in `EXPECTED_METRICS`
- Added `test_go_otlp_scope` method: validates raw OTLP payloads arrive under instrumentation scope `go.runtime`
- Reconciled upstream refactor: `MetricConstraints` TypedDict, `EXPECTED_METRIC_ATTRIBUTE_VALUES`, split test methods
`utils/_context/_scenarios/init.py`: Added `GOMEMLIMIT=500MiB` to `otlp_runtime_metrics` scenario (required for `go.memory.limit` to emit)
`utils/build/docker/golang/app/net-http/main.go`: Added blank import `_ "github.com/DataDog/dd-trace-go/v2/ddtrace/opentelemetry/metric"` to wire OTel metrics in the Go weblog
`manifests/golang.yml`: Removed `missing_feature` entry for `test_otlp_runtime_metrics.py::Test_OtlpRuntimeMetrics`

Workflow

⚠️ Create your PR as draft ⚠️
Work on you PR until the CI passes
Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner.
- Framework is modified, or non obvious usage of it -> get a review from R&P team

Reviewer checklist

Anything but `tests/` or `manifests/` is modified ? I have the approval from R&P team
A docker base image is modified?
- the relevant `build-XXX-image` label is present
A scenario is added, removed or renamed?
- Get a review from R&P team

github-actions · 2026-05-05T14:26:07Z

CODEOWNERS have been resolved as:

manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
tests/test_otlp_runtime_metrics.py                                      @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/build/docker/golang/app/chi/main.go                               @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/echo/main.go                              @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/gin/main.go                               @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/net-http-orchestrion/main.go              @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/net-http/main.go                          @DataDog/dd-trace-go-guild @DataDog/system-tests-core

link04

Thank you!

datadog-datadog-prod-us1 · 2026-06-15T12:14:31Z

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

Testing the test | all-jobs-are-green

🧪 1 Test failed in 1 job

Testing the test | main

tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Status.test_sampling_delay[laravel11x]

from system_tests_suite

assert False
 &#43;  where False = all(&lt;generator object Test_API_Security_Sampling_Different_Status.test_sampling_delay.&lt;locals&gt;.&lt;genexpr&gt; at 0x7f3527cd7bc0&gt;)

self = &lt;tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Status object at 0x7f35504860f0&gt;

    def test_sampling_delay(self):
        &#34;&#34;&#34;Can provide request header schema&#34;&#34;&#34;
    
        assert self.request1.status_code == 200
        schema1 = get_schema(self.request1, &#34;req.headers&#34;)
...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: c62c616 | Docs | Datadog PR Page | Give us feedback!}

…s are enabled (#4962) Following #4803, fixes dual-emission when both `DD_RUNTIME_METRICS_ENABLED=true` and `DD_METRICS_OTEL_ENABLED=true` are set: the legacy v1 runtime metrics shouldn't start. **Fix:** Pre-compute `otelRuntimeMetricsShouldBeEnabled` in `config` (`option.go`) and add a `!otelRuntimeMetricsShouldBeEnabled` guard around the legacy goroutine in `newTracer()`. **Testing:** - `TestTracerRuntimeMetrics` (all subtests) pass - Validated against [system-tests PR #6857](DataDog/system-tests#6857) (`OTLP_RUNTIME_METRICS` scenario): `test_otel_metrics_are_present_and_attributed` and `test_dd_metrics_are_absent` both pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: maximo.bautista <maximo.bautista@datadoghq.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cca3a3265

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Add tests for the new OTel semantic-convention Go runtime metrics (DD_METRICS_OTEL_ENABLED=true) from dd-trace-go PR #4716. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Remove Test_GoOtlpRuntimeMetricsExtended and the OTLP_RUNTIME_METRICS_EXTENDED scenario — the extended env var (DD_OTEL_RUNTIME_METRICS_EXTENDED_ENABLED) no longer exists in the tracer implementation - Add Test_OtlpRuntimeMetrics: missing_feature to golang.yml so the base test is tracked (to be activated when the tracer ships) - Add ddmetric.InstallGlobal() to the net-http weblog before tracer.Start() so the DD OTLP MeterProvider is installed and runtime metrics are actually exported during the OTLP_RUNTIME_METRICS scenario Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…lGlobal Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ide-effect Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…o.memory.limit Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

The test_go_otlp_scope test validated that Go metrics arrived in the raw OTLP payload under the 'go.runtime' instrumentation scope. This is a Go-specific special case that doesn't exist for other languages and is redundant with test_otel_metrics_are_present_and_attributed, which already validates the metric names are present. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ormatting Replace missing_feature removal with v2.10.0-dev version tag (dd-trace-go#4803 was merged after version was bumped to v2.10.0-dev). Fix ruff formatting: restore double blank line before module-level function and remove trailing newline. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Explicitly import `_ "github.com/DataDog/dd-trace-go/v2/ddtrace/opentelemetry/metric"` in chi, echo (covers uds-echo), gin, and net-http-orchestrion so that `otelmetricsinstall.StartHook` is registered for every weblog, not just net-http. This guarantees OTel runtime metrics are intentionally enabled rather than relying on an implicit transitive import. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

link04 approved these changes May 8, 2026

View reviewed changes

anna-git force-pushed the anna.yafi/go-otel-runtime-metrics-tests branch from 831bcc0 to 10a2c32 Compare June 15, 2026 13:35

anna-git force-pushed the anna.yafi/go-otel-runtime-metrics-tests branch from 139d5ac to 67c89b0 Compare June 29, 2026 11:16

anna-git mentioned this pull request Jun 29, 2026

fix(tracer): don't activate runtime metrics v1 if otel runtime metrics are enabled DataDog/dd-trace-go#4962

Merged

anna-git marked this pull request as ready for review July 1, 2026 08:38

anna-git requested review from a team as code owners July 1, 2026 08:38

chatgpt-codex-connector Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread manifests/golang.yml

anna-git and others added 9 commits July 1, 2026 17:15

feat(golang): add OTLP runtime metrics system tests for Go

ed3855b

Add tests for the new OTel semantic-convention Go runtime metrics (DD_METRICS_OTEL_ENABLED=true) from dd-trace-go PR #4716. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(golang): use NewMeterProvider+WithProducer instead of Instal…

8599dfc

…lGlobal Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(golang): use blank import for ddtrace/opentelemetry/metric s…

7acb66d

…ide-effect Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(golang): enable OtlpRuntimeMetrics test and set GOMEMLIMIT for g…

90bf122

…o.memory.limit Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: trigger fresh CI build with dd-trace-go fix merged

c37c103

anna-git force-pushed the anna.yafi/go-otel-runtime-metrics-tests branch from f63ec4a to aa37e51 Compare July 1, 2026 15:17

fix(golang): remove extra blank line from conflict resolution

c62c616

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

anna-git enabled auto-merge (squash) July 1, 2026 15:23

anna-git merged commit 4e52c28 into main Jul 2, 2026
3525 of 3530 checks passed

anna-git deleted the anna.yafi/go-otel-runtime-metrics-tests branch July 2, 2026 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(golang): add OTLP runtime metrics system tests#6857

feat(golang): add OTLP runtime metrics system tests#6857
anna-git merged 10 commits into
mainfrom
anna.yafi/go-otel-runtime-metrics-tests

anna-git commented May 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 5, 2026 •

edited

Loading

Uh oh!

link04 left a comment

Uh oh!

datadog-datadog-prod-us1 Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

anna-git commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Workflow

Reviewer checklist

Uh oh!

github-actions Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

link04 left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anna-git commented May 5, 2026 •

edited

Loading

github-actions Bot commented May 5, 2026 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Jun 15, 2026 •

edited

Loading