init rust weblog#6675
Draft
Eldolfin wants to merge 9 commits into
Draft
Conversation
- passing all css tests !
Contributor
|
|
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This PR introduces the initial Rust weblog implementation using the Axum web framework. The weblog is designed to provide OpenTelemetry tracing and metrics support for system tests, addressing the gap where no Rust implementation existed to show in the feature parity dashboard.
Changes:
- Implements a new Rust weblog application with Axum framework supporting tracing, metrics, and multiple test endpoints (
/,/healthcheck,/stats-unique,/rasp/sqli,/make_distant_call) - Creates Docker build infrastructure with multi-stage Dockerfile and build scripts
- Adds "rust" to the supported languages in the library configuration schema
- Updates Rust manifest to mark specific tests as irrelevant for the weblog variant
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/build/docker/rust/axum/src/main.rs | Main Rust weblog application with OpenTelemetry integration and various test endpoints |
| utils/build/docker/rust/axum/Cargo.toml | Rust project manifest with dependencies for Axum, tracing, and OpenTelemetry |
| utils/build/docker/rust/axum/Cargo.lock | Dependency lock file with all transitive dependencies resolved |
| utils/build/docker/rust/axum.Dockerfile | Multi-stage Docker build configuration for building and running the weblog |
| utils/build/docker/rust/axum/app.sh | Entry point script for the container |
| utils/build/docker/rust/axum/system_tests_library_version.sh | Script to extract library version from Cargo.lock |
| tests/schemas/utils/library/v0.7/config-request.json | Schema update adding "rust" to supported languages list |
| manifests/rust.yml | Test manifest update with specific test expectations |
| .gitignore | Addition of Rust build artifacts to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,2 @@ | |||
| #!/bin/bash | |||
| grep 'name = "datadog-opentelemetry"' ./Cargo.lock -A 1 | grep -Po 'version = "\K.*?(?=")' | |||
There was a problem hiding this comment.
The system_tests_library_version.sh script uses grep -P (Perl-compatible regular expressions), which may not be available in the minimal Debian-based image. The -P flag requires grep to be compiled with PCRE support, which is not guaranteed in slim images. Consider using a more portable approach with standard grep flags or sed.
Suggested change
| grep 'name = "datadog-opentelemetry"' ./Cargo.lock -A 1 | grep -Po 'version = "\K.*?(?=")' | |
| grep 'name = "datadog-opentelemetry"' ./Cargo.lock -A 1 | grep 'version = "' | head -n1 | sed -E 's/.*version = "([^"]+)".*/\1/' |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 744e9c9dfa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+20
to
+23
| libdd-trace-utils = { path = "/binaries/libdatadog/libdd-trace-utils" } | ||
| libdd-common = { path = "/binaries/libdatadog/libdd-common" } | ||
| libdd-tinybytes = { path = "/binaries/libdatadog/libdd-tinybytes" } | ||
| libdd-telemetry = { path = "/binaries/libdatadog/libdd-telemetry" } |
There was a problem hiding this comment.
Do not unconditionally patch crates.io to /binaries/libdatadog/* here, because those directories are not present in the normal system-tests build flow (the repo’s binaries/ is typically empty aside from helper files, and Rust dev setup uses rust-load-from-git/dd-trace-rs instead). With these lines present, cargo fails dependency resolution immediately with “failed to read .../Cargo.toml”, so the new rust/axum weblog image cannot build in default CI/local runs.
Useful? React with 👍 / 👎.
|
- Add /headers, /html, /status, /waf (all methods/subpaths), /spans
- Add /identify, /identify-propagate for user tagging
- Add /params/{value}, /sample_rate_route/{i}, /api_security/sampling/{i}
- Add /tag_value/{tag}/{code} with response header passthrough
- Add appsec event tracking: user_login_success/failure, custom_event (v1+v2)
- Add /users, /returnheaders, /requestdownstream, /vulnerablerequestdownstream
- Add /set_cookie, /session/new, /external_request, /external_request/redirect
- Add /inferred-proxy/span-creation, /createextraservice, /login, /signup
- Add /shell_execution, /rasp/lfi, /rasp/ssrf, /rasp/multiple
- Add /e2e_single_span, /e2e_otel_span
- Set _dd.top_level=1 so library interface can match traces to requests
- Set http.url (with sensitive-param scrubbing), http.useragent, http.client_ip
- Extract client IP from multiple headers (x-forwarded-for, x-real-ip, etc.)
- Add http.referrer_hostname from Referer header
- Add uuid and url crates; add multipart feature to axum
…qli, endpoint_fallback) - Add /sqli with rusqlite in-memory SQLite (unsafe injection for RASP testing) - Add /endpoint_fallback for API security sampling fallback tests - Add /rasp/shi (shell injection via sh -c) and /rasp/cmdi (exec without shell) - Add 12 IAST cookie endpoints (insecure-cookie, no-httponly, no-samesite) - Add IAST hashing endpoints (deduplicate, multiple_hash, secure, md5) - Add /iast/hardcoded_secrets/test_insecure - Add IAST header injection endpoints (exclusion, no-exclusion) - Add IAST sampling endpoints (sampling-by-route-method-count x3) - Add 11 IAST source endpoints (parameter, parametername, header, headername, cookievalue, cookiename, multipart, body, sql) - Add 10 IAST SC (security controls) endpoints - Add rusqlite, md5, sha2 crate dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There is no rust weblog yet so it doesn't show in the feature parity dashboard.
At this point, all tests from the
TRACE_STATS_COMPUTATIONscenario passes. TODO: mark all other endtoend tests as XFAIL in manifestChanges
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present