Skip to content

refactor: simplify literal parsing and textification#151

Draft
wackywendell wants to merge 1 commit into
mainfrom
literal-structure-refactor
Draft

refactor: simplify literal parsing and textification#151
wackywendell wants to merge 1 commit into
mainfrom
literal-structure-refactor

Conversation

@wackywendell

@wackywendell wackywendell commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR moves literal parsing and textification into dedicated modules:

  • src/parser/literals.rs
  • src/textify/literals.rs

The goal is to make literal handling easier to extend without keeping large literal-specific helpers inside the expression parser/textifier.

Changes

  • Extracted literal parsing from src/parser/expressions.rs into src/parser/literals.rs.
  • Extracted literal textification from src/textify/expressions.rs into src/textify/literals.rs.
  • Kept expression parsing/textification as the caller of the shared literal implementations.
  • Changed literal type suffix rendering to construct a Substrait Type and use the existing type textifier, instead of keeping a separate string suffix table.

API Impact

This is intended as an internal structure change. There is no new public extension API in this PR.

Validation

  • cargo check
  • just fmt
  • just check
  • cargo test --doc
  • just test

@wackywendell wackywendell force-pushed the literal-structure-refactor branch from a185f25 to 029332f Compare June 17, 2026 13:42
@wackywendell wackywendell force-pushed the literal-structure-refactor branch from 029332f to ccd533f Compare June 26, 2026 18:24
@wackywendell wackywendell force-pushed the literal-structure-refactor branch from ccd533f to 1a1cd7c Compare July 8, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant