Repository navigation
docs: correct maxPacketSizeBytes type in migration table - #343
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.x-to-3.x migration table lists maxPacketSizeBytes(String... val), but the builder accepts an int. Passing a string as documented fails compilation (String cannot be converted to int), including against the README-recommended 4.4.5 artifact. Change only that parameter type to int, matching the old constructor parameter and the builder API.
Validation: compiled a minimal builder call against 4.4.5 with JDK 17; the documented string argument fails and the integer argument passes. Main/test compilation and 8 selected Event/Message/UTF-8 tests pass on master. Additional bounded public-API checks passed with synthetic payloads sent only to an owned loopback UDP receiver, with origin detection and telemetry disabled. Full transport/CI matrix and real Agent ingestion were not run.