Repository navigation
Attach modifiable-config agent alongside JaCoCo - #13150
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
The JaCoCo coverage agent was treated as a foreign -javaagent, so the modifiable-config agent was never attached to tests with coverage enabled. Spock modules masked this through ConfigTransformSpockExtension. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The JaCoCo exemption matches the coverage agent used by this build and preserves the skip behavior when another Java agent is present.
🤖 Bits Code Review · Commit 852015f
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
01fe76f
into
master
What Does This Do
Attaches the modifiable-config test agent to test JVMs that also run the JaCoCo coverage agent.
Motivation
The plugin skips attaching when another
-javaagentis already present, and it counted JaCoCo as one. So modules with coverage enabled never got the agent, andConfig/InstrumenterConfigstayed unmodifiable at load time. Spock modules hid this becauseConfigTransformSpockExtensionrewritesConfigat runtime. Modules with no Spock, such asinternal-apionce its Groovy is removed, fail with "Config/InstrumenterConfig INSTANCE fields are not modifiable".Additional Notes
This affects every module's tests, so it is a separate PR.
:communication:test(Spock + JUnit, 297 tests) passes with both agents attached.#13152 (Groovy cleanup for
internal-api) is stacked on this one.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue🤖 Generated with Claude Code