Repository navigation
🍒 13109 - Fix stale type descriptions when transforming multi-release classes - #13134
Conversation
Tomcat can load a versioned class from a multi-release JAR while returning the base entry through getResource(). Reusing metadata cached from that resource could lead to a VerifyError if it happened to be incompatible with the JVM-supplied (versioned) bytes. Retain a LazyType backed by the JVM-supplied bytes for the current target. Bypass shared metadata for that target while reusing its parsed description throughout the transform, even after local-cache eviction. Previously issued deferred references also resolve through this target. Add regression coverage for outline and full descriptions, cache eviction, previously issued deferred references, and subsequent transforms. (cherry picked from commit e5e3f7c)
mcculls
added
type: bug fix
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de550083cc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The target description uses JVM-provided bytecode consistently across cache reuse and retained references, addressing stale multi-release class descriptions. Static review found no actionable regression; runtime behavior remains unverified.
🤖 Bits Code Review · Commit de55008
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Backport #13109 to release/v1.68.x