Repository navigation
Add functional class injection tests using startup instrumentation - #135
Merged
Merged
Conversation
mcculls
force-pushed
the
mcculls/class-injection-ft
branch
from
October 17, 2026 10:49
a274057 to
5ea45ca
Compare
mcculls
marked this pull request as ready for review
October 17, 2026 10:54
mcculls
requested review from
bric3 and
dougqh
and removed request for
a team
October 17, 2026 10:54
dougqh
reviewed
Oct 20, 2026
dougqh
left a comment
dougqh
left a comment
There was a problem hiding this comment.
Nice to have functional coverage here. A few suggestions inline, all non-blocking — leaving them to your discretion.
These came from a Claude Code review that I've read through; they haven't been reproduced.
dougqh
approved these changes
Oct 20, 2026
dougqh
left a comment
dougqh
left a comment
There was a problem hiding this comment.
Claude has a few suggestions - I'll leave those to your discretion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds functional class injection tests backed by instrumentation supplied by a startup test agent. Covers bootstrap injection, injection into an isolated class loader, a supplied protection domain, repeated injection, and calls between injected classes.
Motivation
Exercise class injection in real test JVMs across the supported Java versions, beyond verifying the generated glue bytecode.
Additional Notes
The new
instrument-testingconvention plugin supplies the test agent to every test JVM, including the additional Java version tasks.Adds
JAVA_27_HOMEto Gradle's JDK environment list so Java 27 installations can be discovered.Validation:
Contributor Checklist
Jira ticket: not provided.