fix(dashboards,synthetics_private_locations): drop stale restricted_roles under new flag (4/4)#632
Draft
michael-richey wants to merge 1 commit into
Conversation
…oles under new flag Completes the rollout by applying the flat-list drop-aware filter to the two remaining resource types with a `restricted_roles` list: - dashboards: `restricted_roles` - synthetics_private_locations: `metadata.restricted_roles` Both previously had trivial pass-through `connect_id` overrides; they now get a `connect_resources` override that filters stale roles under `--drop-unresolvable-principals` while keeping widget/other connections on the generic path and preserving the empty-list access-elevation hard-fail. Adds a new unit test module for synthetics_private_locations. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
michael-richey
force-pushed
the
drop-unresolvable-principals-monitors-synthetics
branch
from
518113c to
27fd78f
Compare
michael-richey
force-pushed
the
drop-unresolvable-principals-dashboards-spl
branch
from
e163cc1 to
a16b6d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Stacked PR 4 of 4. Base:
drop-unresolvable-principals-monitors-synthetics(PR #631). Completes the rollout.This PR
Applies the flat-list drop-aware filter to the two remaining resource types with a
restricted_roleslist:restricted_rolesmetadata.restricted_rolesBoth previously had trivial pass-through
connect_idoverrides; they now get aconnect_resourcesoverride that filters stale roles under--drop-unresolvable-principalswhile keeping widget/other connections on the generic path and preserving the empty-list access-elevation hard-fail.Testing
New
connect_resourcesdrop suite intest_dashboards.pyand a newtest_synthetics_private_locations.pymodule (drop, empty-list risk, middle-element regression, flag-off, no-op-when-absent). Green;ruffclean.🤖 Generated with Claude Code