Skip to content

fix(downtime_schedules): request include=created_by on source fetches #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riyazsh merged 6 commits into from
Jul 15, 2026
Merged

fix(downtime_schedules): request include=created_by on source fetches #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1daf120
fix(downtime_schedules): request `include=created_by` on source fetches
riyazsh Jul 14, 2026
7db2047
Match sibling convention: raw `["data"]` unwrap on per-id GET
riyazsh Jul 14, 2026
3f5b089
Drop unused import and tighten envelope-unwrap assertion
riyazsh Jul 14, 2026
c949a95
Re-record integration cassettes for new include=created_by query param
riyazsh Jul 14, 2026
5fdea84
Remove stray cassette at wrong path (from earlier test run)
riyazsh Jul 14, 2026
f68cd05
Re-record cassettes with vcrpy fork (captures request bodies)
riyazsh Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion datadog_sync/model/downtime_schedules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,28 @@ class DowntimeSchedules(BaseResource):
# Additional DowntimeSchedules specific attributes

async def get_resources(self, client: CustomClient) -> List[Dict]:
# `include=created_by` populates `relationships.created_by.data.id` on
# each downtime. Downstream consumers (e.g. HAMR managed-sync's OBO
# grouper) key on that field to route the resource under its creator's
# identity; without the include, the LIST response omits `relationships`
# entirely and downstream code falls back to a service-account identity.
resp = await client.paginated_request(client.get)(
self.resource_config.base_path,
pagination_config=self.pagination_config,
params={"include": "created_by"},
)

return resp

async def import_resource(self, _id: Optional[str] = None, resource: Optional[Dict] = None) -> Tuple[str, Dict]:
if _id:
source_client = self.config.source_client
resource = await source_client.get(self.resource_config.base_path + f"/{_id}")
resource = (
await source_client.get(
self.resource_config.base_path + f"/{_id}",
params={"include": "created_by"},
)
)["data"]

if resource["attributes"].get("canceled"):
raise SkipResource(resource["id"], self.resource_type, "Downtime is canceled.")
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/cassettes/test_cli/TestCli.test_cleanup.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2026-05-19T10:21:20.061536-04:00
2026-07-14T16:27:42.752855-04:00
23,892 changes: 12,070 additions & 11,822 deletions tests/integration/cassettes/test_cli/TestCli.test_cleanup.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/integration/cassettes/test_cli/TestCli.test_import.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2026-05-19T10:20:19.112442-04:00
2026-07-14T16:26:50.134799-04:00
15,738 changes: 10,402 additions & 5,336 deletions tests/integration/cassettes/test_cli/TestCli.test_import.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/integration/cassettes/test_cli/TestCli.test_import_without_verify_ddr_status.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2026-05-19T10:20:41.186353-04:00
2026-07-14T16:27:20.145500-04:00
20,500 changes: 9,440 additions & 11,060 deletions tests/integration/cassettes/test_cli/TestCli.test_import_without_verify_ddr_status.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/integration/cassettes/test_cli/TestCli.test_migrate.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2026-05-19T10:21:07.234257-04:00
2026-07-14T16:27:35.358959-04:00
28,485 changes: 12,708 additions & 15,777 deletions tests/integration/cassettes/test_cli/TestCli.test_migrate.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/integration/cassettes/test_cli/TestCli.test_migrate_without_verify_ddr_status.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2026-05-19T10:20:54.627394-04:00
2026-07-14T16:27:27.444395-04:00
Loading
Loading