Skip to content

fix: update pprof prebuild cleanup for @datadog/pprof 5.14.4 #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucaspimentel merged 3 commits into from
Aug 25, 2026
Merged

fix: update pprof prebuild cleanup for @datadog/pprof 5.14.4 #813

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8ecaeb
fix: update pprof prebuild cleanup for @datadog/pprof 5.14.4
lucaspimentel Aug 25, 2026
a9e6831
fix comment
lucaspimentel Aug 25, 2026
1ec755e
Potential fix for pull request finding
lucaspimentel Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,19 @@ RUN rm -rf /nodejs/node_modules/aws-xray-sdk-core/node_modules/aws-sdk
# Remove heavy files from @datadog/pprof which aren't used in a lambda environment
# TODO: Ship individual bindings per platform and depend on that instead.
# TODO: Split x64 and ARM so that each image only has the binaries for its architecture.
# Lambda's supported Node.js runtimes use glibc on x64 or arm64.
# Remove non-Linux platform prebuilds
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/darwin-arm64
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/darwin-x64
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/linux-arm
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/linuxmusl-arm64
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/linuxmusl-x64
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/win32-ia32
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/win32-x64
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/node-111.node
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/node-120.node
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/node-131.node
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/node-141.node
# Remove musl prebuilds (Lambda uses glibc, not musl)
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/dd_pprof.musl.node.*.node
# Remove ABIs for non-LTS Node versions not supported on Lambda
# Lambda supports Node 18 (abi108), Node 20 (abi115), Node 22 (abi127), Node 24 (abi137), and Node 26 (abi147)
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/dd_pprof.node.abi111.node
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/dd_pprof.node.abi120.node
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/dd_pprof.node.abi131.node
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/dd_pprof.node.abi141.node

# Remove unused @datadog/native-appsec prebuilds for non-Lambda platforms.
# Lambda runs on Amazon Linux 2 (glibc), on x64 or arm64.
Expand Down
Loading