Skip to content

perf(build): set -Ctarget-cpu for Graviton2 / x86-64-v2 #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
duncanista wants to merge 1 commit into
base: jordan.gonzalez/cold-start-instrumentation/feature
Choose a base branch
from
Draft

perf(build): set -Ctarget-cpu for Graviton2 / x86-64-v2 #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion images/Dockerfile.bottlecap.alpine.compile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,15 @@ RUN --mount=type=cache,target=/root/.cargo/git \
else \
export FEATURES=default; \
fi; \
# Tune codegen for the known Lambda CPUs: arm64 is Graviton2 (neoverse-n1),
# x86_64 uses the universally-safe x86-64-v2 baseline (NOT v3, which risks SIGILL).
if [ "${PLATFORM}" = "aarch64" ]; then TARGET_CPU="neoverse-n1"; else TARGET_CPU="x86-64-v2"; fi; \
if [ "${PLATFORM}" = "x86_64" ]; then \
# The `libddwaf` crate links against static objects that require `libclang_rt.builtins`, but
# this is not presented to the linker by default on this platform, so we force it in.
export RUSTFLAGS="${RUSTFLAGS:-} -Clinker=clang -L$(dirname $(clang --print-file-name="libclang_rt.builtins-$(uname -m).a")) -lclang_rt.builtins-$(uname -m)"; \
export RUSTFLAGS="${RUSTFLAGS:-} -Clinker=clang -L$(dirname $(clang --print-file-name="libclang_rt.builtins-$(uname -m).a")) -lclang_rt.builtins-$(uname -m) -Ctarget-cpu=${TARGET_CPU}"; \
else \
export RUSTFLAGS="${RUSTFLAGS:-} -Ctarget-cpu=${TARGET_CPU}"; \
fi; \
# We use a wrapper to allow `libddwaf-sys`' build.rs to be compiled with
# -Ctarget-feature=-crt-static so that it is capable of dynamically loading
Expand Down
5 changes: 4 additions & 1 deletion images/Dockerfile.bottlecap.compile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,12 @@ RUN --mount=type=cache,target=/usr/local/cargo/git \
export BUILD_MODE=debug; \
export BUILD_FLAG=""; \
fi; \
# Tune codegen for the known Lambda CPUs: arm64 is Graviton2 (neoverse-n1),
# x86_64 uses the universally-safe x86-64-v2 baseline (NOT v3, which risks SIGILL).
if [ "${PLATFORM}" = "aarch64" ]; then TARGET_CPU="neoverse-n1"; else TARGET_CPU="x86-64-v2"; fi; \
# The `libddwaf` crate links against static objects that require `libclang_rt.builtins`, but
# this is not presented to the linker by default on this platform, so we force it in.
export RUSTFLAGS="${RUSTFLAGS:-} -Clinker=clang -L$(dirname $(clang --print-file-name="libclang_rt.builtins-$(uname -m).a")) -lclang_rt.builtins-$(uname -m)"; \
export RUSTFLAGS="${RUSTFLAGS:-} -Clinker=clang -L$(dirname $(clang --print-file-name="libclang_rt.builtins-$(uname -m).a")) -lclang_rt.builtins-$(uname -m) -Ctarget-cpu=${TARGET_CPU}"; \
cargo +stable build --verbose --locked --no-default-features --features="${FEATURES}" ${BUILD_FLAG} && \
mkdir -p /tmp/out && cp "/tmp/dd/bottlecap/target/${BUILD_MODE}/bottlecap" /tmp/out/bottlecap

Expand Down
Loading