Fix DORA deployment and incident read responses to use date-time timestamps#3746
Merged
api-clients-generation-pipeline[bot] merged 2 commits intoJul 7, 2026
Merged
Conversation
nogates
force-pushed
the
datadog-api-spec/generated/6101
branch
from
3589f6d to
4f9311e
Compare
The Python client serializes tz-aware datetimes via datetime.isoformat(), producing a "+00:00" UTC offset, while recorded cassettes use "Z". Both denote the same instant, but the VCR replay body matcher compared them as differing strings, so replay-only scenarios that send a datetime in the request body (e.g. DORA ListDORADeployments) fail to match their cassette. The matcher also only recognized "text/json", so "application/json" bodies skipped JSON-aware comparison entirely and fell back to a raw byte compare.
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/6101
branch
from
4f9311e to
2e712fc
Compare
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/6101
branch
from
2e712fc to
52566ba
Compare
nogates
approved these changes
Jul 7, 2026
api-clients-generation-pipeline
Bot
deleted the
datadog-api-spec/generated/6101
branch
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 7, 2026
…stamps (#3746) * tests: match request bodies with equivalent datetime timezone notations The Python client serializes tz-aware datetimes via datetime.isoformat(), producing a "+00:00" UTC offset, while recorded cassettes use "Z". Both denote the same instant, but the VCR replay body matcher compared them as differing strings, so replay-only scenarios that send a datetime in the request body (e.g. DORA ListDORADeployments) fail to match their cassette. The matcher also only recognized "text/json", so "application/json" bodies skipped JSON-aware comparison entirely and fell back to a raw byte compare. * Regenerate client from commit dcda436 of spec repo --------- Co-authored-by: Francesco Pighi <francesco.pighi@datadoghq.com> Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> dce1052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#6101 Test branch datadog-api-spec/test/henry.walsh/sdcd-2820/dora-list-deployment-return-update