Skip to content

Deprecate OCI config listing endpoint #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
api-clients-generation-pipeline wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deprecate OCI config listing endpoint #4259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141466,7 +141466,11 @@ paths:
- cloud_cost_management_write
/api/v2/cost/oci_config:
get:
description: List the OCI configs.
deprecated: true
description: |-
**Note**: This endpoint is deprecated. View OCI accounts in Cloud Cost Settings in the Datadog web application instead.

List the OCI configs.
operationId: ListCostOCIConfigs
responses:
"200":
Expand Down Expand Up @@ -141507,6 +141511,7 @@ paths:
operator: OR
permissions:
- cloud_cost_management_read
x-sunset: "2027-01-01"
/api/v2/cost/recommendations:
post:
description: List cost recommendations matching a filter, with pagination and sorting.
Expand Down
14 changes: 13 additions & 1 deletion src/main/java/com/datadog/api/client/v2/api/CloudCostManagementApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7828,7 +7828,9 @@ public ApiResponse<GCPUsageCostConfigsResponse> listCostGCPUsageCostConfigsWithH
*
* @return OCIConfigsResponse
* @throws ApiException if fails to make API call
* @deprecated
*/
@Deprecated
public OCIConfigsResponse listCostOCIConfigs() throws ApiException {
return listCostOCIConfigsWithHttpInfo().getData();
}
Expand All @@ -7839,7 +7841,9 @@ public OCIConfigsResponse listCostOCIConfigs() throws ApiException {
* <p>See {@link #listCostOCIConfigsWithHttpInfoAsync}.
*
* @return CompletableFuture&lt;OCIConfigsResponse&gt;
* @deprecated
*/
@Deprecated
public CompletableFuture<OCIConfigsResponse> listCostOCIConfigsAsync() {
return listCostOCIConfigsWithHttpInfoAsync()
.thenApply(
Expand All @@ -7849,7 +7853,10 @@ public CompletableFuture<OCIConfigsResponse> listCostOCIConfigsAsync() {
}

/**
* List the OCI configs.
* <strong>Note</strong>: This endpoint is deprecated. View OCI accounts in Cloud Cost Settings in
* the Datadog web application instead.
*
* <p>List the OCI configs.
*
* @return ApiResponse&lt;OCIConfigsResponse&gt;
* @throws ApiException if fails to make API call
Expand All @@ -7861,7 +7868,10 @@ public CompletableFuture<OCIConfigsResponse> listCostOCIConfigsAsync() {
* <tr><td> 403 </td><td> Forbidden </td><td> - </td></tr>
* <tr><td> 429 </td><td> Too many requests </td><td> - </td></tr>
* </table>
*
* @deprecated
*/
@Deprecated
public ApiResponse<OCIConfigsResponse> listCostOCIConfigsWithHttpInfo() throws ApiException {
Object localVarPostBody = null;
// create path and map variables
Expand Down Expand Up @@ -7895,7 +7905,9 @@ public ApiResponse<OCIConfigsResponse> listCostOCIConfigsWithHttpInfo() throws A
* <p>See {@link #listCostOCIConfigsWithHttpInfo}.
*
* @return CompletableFuture&lt;ApiResponse&lt;OCIConfigsResponse&gt;&gt;
* @deprecated
*/
@Deprecated
public CompletableFuture<ApiResponse<OCIConfigsResponse>> listCostOCIConfigsWithHttpInfoAsync() {
Object localVarPostBody = null;
// create path and map variables
Expand Down
7 changes: 4 additions & 3 deletions src/test/resources/generated-test/test-server
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import re
import tempfile
import threading
import uuid
from datetime import datetime, timezone
from datetime import UTC, datetime
from http import HTTPStatus
from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer
from pathlib import Path
Expand Down Expand Up @@ -435,7 +435,8 @@ def _json_contains(actual: Any, expected: Any) -> bool:
return all(key in actual and _json_contains(actual[key], value) for key, value in expected.items())
if isinstance(expected, list) and isinstance(actual, list):
return len(expected) == len(actual) and all(
_json_contains(actual_item, expected_item) for actual_item, expected_item in zip(actual, expected)
_json_contains(actual_item, expected_item)
for actual_item, expected_item in zip(actual, expected, strict=False)
)
return actual == expected

Expand All @@ -460,7 +461,7 @@ def _slug(value: str) -> str:


def _now_iso() -> str:
return datetime.now(timezone.utc).isoformat().replace("+00:00", "Z")
return datetime.now(UTC).isoformat().replace("+00:00", "Z")


def _read_json(path: Path) -> dict[str, Any]:
Expand Down
Loading