docs(apps): require HTTP action for external requests - #482
Closed
ameesha wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@datadog/action-catalog/http/http.fetchand Node.js networking calls, and provide a copyable example that does not require a connection.connectionIdis optional and should only be supplied when an existing HTTP connection contains authentication information the request needs.3.2.12to3.2.13so the guidance is included in the next published version.Why
Agents creating Datadog apps need an explicit networking boundary without being told to require configuration most users will not have. External calls should use the HTTP action, but that action works without a connection. HTTP connections are created manually in the Datadog UI, so apps should only reference one when it already exists and provides required authentication.
Validation
yarn cli integritygit diff --check