chore: update mkdocs-rss-plugin fork to latest commit with tests#74
Merged
Conversation
…improved fix - Fork now includes test suite for RSS validation compliance - Double-encoding fix moved from template to Python (html_module.unescape) - Cleaner solution: unescape at source, let Jinja |e do single escape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the forked mkdocs-rss-plugin reference to the latest commit, which includes an improved approach for the double-encoding fix and a test suite.
Upstream PR: Guts/mkdocs-rss-plugin#451
What changed in the fork
replace()filters in the Jinja template, now useshtml_module.unescape()in plugin.py before passing data to the template. Jinja's|ethen does a single correct escape.tests/test_rss_validation.pycovering all RSS validation fixes, plus a fixture with special characters (& < >). All 36 tests pass.This is a follow-up to #73 which initially switched to the fork.