Configure transactions manually on <3.12 - #5580
Open
adamnovak wants to merge 1 commit into
Open
Conversation
The "DEFERRED" isolation_level we use on Python 3.12 doesn't *actually* seem to put table schema changes from the migrations into a transaction we can roll back. This adds an explicit "BEGIN DEFERRED" which makes the schema changes go away when we rollback(). This very much does not "start a transaction" (see <https://sqlite.org/forum/forumpost/98f04f5585b83eb1>), so I'm not sure why it works if the database is *really* in the "DEFERRED" isolation_level which is supposed to be basically the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "DEFERRED" isolation_level we use on Python 3.12 doesn't actually seem to put table schema changes from the migrations into a transaction we can roll back.
This adds an explicit "BEGIN DEFERRED" which makes the schema changes go away when we rollback(). This very much does not "start a transaction" (see https://sqlite.org/forum/forumpost/98f04f5585b83eb1), so I'm not sure why it works if the database is really in the "DEFERRED" isolation_level which is supposed to be basically the same thing.
Changelog Entry
To be copied to the draft changelog by merger:
Reviewer Checklist
issues/XXXX-fix-the-thingin the Toil repo, or from an external repo.camelCasethat want to be insnake_case.docs/running/{cliOptions,cwl,wdl}.rstMerger Checklist