CTM-628 pd-balanced boot disks are actually pretty good - #4925
Draft
aednichols wants to merge 6 commits into
Draft
CTM-628 pd-balanced boot disks are actually pretty good#4925aednichols wants to merge 6 commits into
pd-balanced boot disks are actually pretty good#4925aednichols wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4925 +/- ##
===========================================
+ Coverage 73.87% 73.88% +0.01%
===========================================
Files 131 131
Lines 11207 11208 +1
Branches 957 949 -8
===========================================
+ Hits 8279 8281 +2
+ Misses 2928 2927 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take advantage of
pd-balanced"baseline performance" of 3,000 IOPS + 140 MiBps [0].Those (great) performance figures are suspiciously identical to Hyperdisk Balanced [1], the newest disk type.
Indeed,
pd-balancedgot this upgrade in 2022 [2] just before Hyperdisk GA [3]; perhaps it's now implemented on a shared platform with Hyperdisk.250 GB
pd-standard: 30 MiB/s, 188 IOPS read, 375 IOPS write100 GB
pd-balanced: 168 MiB/s, 3,600 IOPS read/write[0] https://docs.cloud.google.com/compute/docs/disks/performance#baseline_performance
[1] https://docs.cloud.google.com/compute/docs/disks/hd-types/hyperdisk-balanced#default-perf
[2] https://docs.cloud.google.com/compute/docs/release-notes-archive#November_14_2022
[3] https://docs.cloud.google.com/compute/docs/release-notes-archive#March_13_2023
Testing to do: evaluate against scenarios in #3594 to make sure we have enough space for large custom images. The free space math changed significantly with #4922.