Skip to content

test(ui): wait for the run job before counting engine calls in sync_render_test.go (macOS race) (#280) #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielNetzer merged 1 commit into from
Oct 27, 2026
Merged

test(ui): wait for the run job before counting engine calls in sync_render_test.go (macOS race) (#280) #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lab/internal/ui/sync_render_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ func TestSyncRenderStartIntakeRefusedWhenTheIssueClosedMeanwhile(t *testing.T) {
}
// An open Issue starts.
viewOf[RunJobView](t, do(t, h, gatePost("/api/runs", `{"issue":9}`)), http.StatusAccepted)
waitJob(t, h, runKey(9))
if n := d.calls(); n != 1 {
t.Fatalf("an open Issue did not start: %d engine calls", n)
}
Expand Down Expand Up @@ -309,6 +310,7 @@ func TestSyncRenderStartIntakeEnforcesTheStartableRule(t *testing.T) {
}
// A row the Issues view shows startable starts.
viewOf[RunJobView](t, do(t, h, gatePost("/api/runs", `{"issue":5}`)), http.StatusAccepted)
waitJob(t, h, runKey(5))
if n := d.calls(); n != 1 {
t.Fatalf("row 5 did not start: %d engine calls", n)
}
Expand Down Expand Up @@ -380,6 +382,7 @@ func TestSyncRenderStartIntakeNeedsASnapshotFromAfterItBegan(t *testing.T) {
// Same clock: the forced read is from after the start and Issue 1 starts.
h.(*handler).forge.now = clk.now
viewOf[RunJobView](t, do(t, h, gatePost("/api/runs", `{"issue":1}`)), http.StatusAccepted)
waitJob(t, h, runKey(1))
if n := d.calls(); n != 1 {
t.Fatalf("a current read did not start: %d engine calls", n)
}
Expand Down
Loading