Skip to content

refactor(ui): split app.js/style.css into per-view ES modules and stylesheets, explicit served allowlist (no behaviour change) (#262) - #270

Merged
DanielNetzer merged 3 commits into
mainfrom
forgecell/issue-262-031c42e776bf6ca602b0bfbe
Oct 27, 2026
Merged

DanielNetzer merged 3 commits into
mainfrom
forgecell/issue-262-031c42e776bf6ca602b0bfbe

Conversation

@DanielNetzer

Copy link
Copy Markdown
Owner

Implements issue #262.

Molecule: mol-262-fc616867b26844dd37106edc
Formula: forgecell-github-issue
Base: 6e48212c76bb7475c270664c31a44ec269bbc7a5
Delivery: ec2625c1ad932b0e9adf629a984e7296435428de

Awaiting exact-commit CI and human review. Harness-reported checks are not independent CI evidence. No merge, deployment or issue closure is authorized.

Daniel Netzer and others added 3 commits October 27, 2026 14:37
…lesheets, explicit served allowlist (no behaviour change) (#262)
…ed after the split)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DanielNetzer

Copy link
Copy Markdown
Owner Author

Review: LOW findings (not fixed in this slice)

  1. The cascade-order test is weak. Splitting made every base.css rule load before every view-sheet rule, so a same-specificity base rule that used to come after a view rule now loses. A hand check of the risky selectors found only .inbox-watch, which is fixed, and .shelf in forced colors, which is fixed in this revision. A test should fail when a view sheet redefines a base.css selector and property at equal specificity.
  2. web/style.css is no longer served and nothing references it. It's removed in this PR's delivery commit, because the coding harness can't delete files.

Fixed in this slice:

  • the forced-colors .shelf background;
  • the import check now also rejects dynamic import( and export … from.

@DanielNetzer
DanielNetzer marked this pull request as ready for review October 27, 2026 12:38
@DanielNetzer
DanielNetzer merged commit 5a63855 into main Oct 27, 2026
2 checks passed
@DanielNetzer
DanielNetzer deleted the forgecell/issue-262-031c42e776bf6ca602b0bfbe branch October 27, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant