fix: balance hero subcopy line lengths - #30
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
dalestudy | 08e6503 | Commit Preview URL Branch Preview URL |
Aug 16 2026, 01:28 AM |
devkade
approved these changes
Aug 16, 2026
devkade
left a comment
devkade
left a comment
Collaborator
There was a problem hiding this comment.
확인해봤을 때 balance 사용시의 한/영 가독성이 더 높아 보입니다. 좋은 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
데스크톱에서 히어로 서브카피가 3줄로 떨어지면서 마지막 줄에 "동료들이 기다립니다."만 남던 문제를 해결합니다.
text-wrap: pretty는 마지막 줄에 한 어절만 남는 걸 피하려 시도할 뿐, 줄 길이를 균등하게 맞추지는 않습니다. 바로 위.hero h1은 이미text-wrap: balance를 쓰고 있어 제목과 서브카피의 줄바꿈 방식도 서로 달랐습니다. 서브카피도balance로 맞췄습니다.이슈에서 함께 제안된
max-width확대(560px → 600~640px)는 택하지 않았습니다. 카피 길이에 맞춰 컨테이너를 튜닝하는 방식이라 카피가 한 어절만 바뀌어도 다시 깨집니다.