CMake plumbing to build the loader (2) by illwieckz · Pull Request #14 · DaemonEngine/native_client

illwieckz · 2026-06-21T23:36:17Z

Replay of:

CMake plumbing to build the loader #2

GitHub doesn't allow me to re-open it…

slipher

Some things we aren't going to use that could be removed: MIPS, Android, and "zero-based sandbox".

slipher · 2026-07-10T08:23:08Z

+	set(LD_EMUL "armelf_linux_eabi")
+	set(RESERVE_TOP "0x40002000")
+
+	if (YOKAI_CXX_COMPILER_CLANG_COMPATIBILITY)


You have two different spellings of CLANG_COMPATIBILITY here

Not sure to get what you mean.

slipher · 2026-07-18T22:27:02Z

+endif()
+
+# From SetUpLinuxEnvMips() from (root)/SConstruct.
+if (YOKAI_TARGET_SYSTEM_LINUX_COMPATIBILITY AND YOKAI_TARGET_ARCH_MIPSEL)


Why is there mips stuff? We shouldn't waste our time on stuff we're not going to use.

The reason why there was mips stuff is that when I ported it, I translated the scons files line by line by hand and I didn't want to miss anything, just in case.

I added a commit to remove that mips stuff from CMake.

slipher · 2026-07-18T22:33:38Z

+	)
+
+	if (YOKAI_CXX_COMPILER_MSVC)
+		list(APPEND PLATFORM_INPUTS "win/nacl_time.c")


The Windows one worked for me with MinGW. It's probably better to use this as the *nix compatibility layers might be lossy.

Was it MinGW on Windows?

Ah, maybe I just need -lwinmm. It builds but not link.

That was that.

slipher · 2026-07-18T22:34:53Z

+
+	if (YOKAI_CXX_COMPILER_MSVC)
+		list(APPEND PLATFORM_FLAGS "/D_CRT_RAND_S")
+		list(APPEND PLATFORM_FLAGS "/D_UNICODE")


These defines act for MinGW too. That's probably why you had to add explicit W suffixes to some function names.

Didn't know MinGW could receive MinGW-style /X options. 🙂️

Oh, maybe you meant to use -D 🤣️

Well, the flag passing was also broken.

slipher · 2026-07-18T22:35:25Z

+		"linux/nacl_semaphore.c"
+	)
+
+#TODO:	kernel_version = list(map(int, platform.release().split('.', 2)[:2]))


Let's not do it :)

Sure! 😅️

It's just that I translated from scons line by line and commented out things like that, with the TODO: flag as a generic flag to find them if I needed to review them later.…

Cleaned-up.

slipher · 2026-07-18T22:40:26Z

+add_library(nrd OBJECT "nrd_xfer.c")
+list(APPEND NRD_XFER_LIBS nrd)
+
+if (NOT YOKAI_TARGET_SYSTEM_WINDOWS)


this should be NOT MSVC for the aliasing flag

slipher · 2026-07-18T22:46:39Z

+	list(APPEND NRD_FLAGS "-fno-strict-aliasing") # This was only a C flag in build.scons
+	list(APPEND NRD_FLAGS "-Wno-missing-field-initializers")
+	string(REPLACE ";" " " NRD_FLAGS_STRING "${NRD_FLAGS}")
+	set_target_properties(nrd PROPERTIES COMPILE_FLAGS "${NRD_FLAGS_STRING}")


COMPILE_FLAGS is supposedly deprecated. Maybe if you use TARGET_COMPILE_OPTIONS this string replacement nonsense won't be needed?

slipher · 2026-07-18T22:50:58Z

+#                sel_ldr binary
+# TODO(robertm): see who really needs them and remove
+if (YOKAI_TARGET_SYSTEM_WINDOWS)
+# FIXME: Unused for now.


Probably it builds without that due to CMAKE_C(XX)_STANDARD_LIBRARIES.

slipher · 2026-07-18T22:55:16Z

+endif()
+
+if (BUILD_NACL_LOADER AND YOKAI_TARGET_SYSTEM_WINDOWS)
+	option(FORCE_NO_TRUSTED_BUILD "Prevent use of trusted toolchain." OFF)


This doesn't seem to have any relevance when the build uses only one toolchain to begin with.

slipher · 2026-07-18T22:57:30Z

+
+# Using this optimization when building with GCC breaks the program on armhf:
+# > Illegal instruction
+if (NOT YOKAI_CXX_COMPILER_CLANG_COMPATIBILITY AND (YOKAI_TARGET_ARCH_ARMHF OR YOKAI_TARGET_ARCH_ARMEL))


I think ARMEL is not really a valid target platform since the sandbox expects to be able to use a specific set up CPU instructions.

armel is just armhf with hard-float being optional. In the end the armel topic is probably just the Android topic.

…-reorder disabled on armhf The -ftoplevel-reorder option breaks the build for armhf.

…parameter

illwieckz · 2026-10-05T23:48:37Z

Some things we aren't going to use that could be removed: MIPS, Android, and "zero-based sandbox".

All of that was there because I didn't want to overlook anything when tranlasting from scons to cmake.

I NUKED added commits to NUKE the MIPS support and the zero-based sandbox thing in CMake.

The Android stuff, I'm less convinced.

The only known working implementation is for i686 MSVC. - detection was already disabled and marked at not working with amd64 MSVC, - detection was already disabled on amd64 MinGW because amd64 Windows was tested, not just amd64 MSVC, - there is no MinGW implementation in the code, - this disables detection on MinGW explicitely whatever the architecture.

illwieckz added 2 commits April 7, 2025 20:20

cmake: add MinGW CMake toolchains for cross-compilation

82a062b

cmake: add CMake scripts to build sel_ldr and nacl_helper_bootstrap

1e2d0d0

illwieckz added the enhancement New feature or request label Jun 21, 2026

illwieckz changed the title ~~Write a CMakeLists.txt to build the NaCl loader~~ Write a CMakeLists.txt to build the NaCl loader (2) Jun 21, 2026

This was referenced Jun 21, 2026

Make the loader runs on 16k page size kernel with CMake (2) #15

Closed

Restoring the (almost) complete history #13

Closed

illwieckz changed the title ~~Write a CMakeLists.txt to build the NaCl loader (2)~~ CMake plumbing for the loader (2) Jun 21, 2026

illwieckz changed the title ~~CMake plumbing for the loader (2)~~ CMake plumbing to build loader (2) Jun 22, 2026

illwieckz mentioned this pull request Jun 22, 2026

Merging my work #19

Open

illwieckz changed the title ~~CMake plumbing to build loader (2)~~ CMake plumbing to build the loader (2) Jun 22, 2026

illwieckz force-pushed the illwieckz/cmake branch from c262e03 to 0ee1872 Compare June 25, 2026 07:15

illwieckz mentioned this pull request Jun 25, 2026

Add CMake install target #28

Closed

illwieckz force-pushed the illwieckz/cmake branch from 0ee1872 to 251b9ab Compare June 26, 2026 12:54

illwieckz added 2 commits June 26, 2026 23:35

cmake: use path sanitization

257f46c

cmake: add install target

ef89f09

illwieckz force-pushed the illwieckz/cmake branch 5 times, most recently from a22c699 to d746c29 Compare July 3, 2026 00:21

illwieckz force-pushed the illwieckz/cmake branch from d746c29 to fbbaa75 Compare July 7, 2026 07:28

This was referenced Jul 13, 2026

Make the loader code compatible with MinGW (2) #17

Merged

Skip the CPU detection on MinGW like MSVC for amd64 #22

Open

CMake plumbing to build tls_edit #43

Open

Building the NativeClient loader as part of the engine build? DaemonEngine/Daemon#1879

Open

illwieckz force-pushed the illwieckz/cmake branch from fbbaa75 to 586202a Compare July 14, 2026 08:58

slipher reviewed Jul 18, 2026

View reviewed changes

illwieckz added 3 commits October 6, 2026 00:48

cmake: NUKE ZERO_BASED_SANDBOX

bfa7cb7

cmake: NUKE mipsel

d50db34

fixup: cmake: Windows flags on MinGW too

05ccb01

illwieckz added 7 commits October 6, 2026 00:54

fixup: cmake: Win time on MinGW too

ecdc33b

cmake: NUKE kernel check we will never do

c6430fd

fixup: cmake: no GCC flags on MSVC

a68f22a

fixup: cmake: NUKE JWasm

1116439

cmake: use size optimization for nacl_helper_bootstrap, with toplevel…

f5911b1

…-reorder disabled on armhf The -ftoplevel-reorder option breaks the build for armhf.

win32: silence the warning for the unused CheckCPUFeatureDetection() …

b6e921f

…parameter

cmake: add the Yokai CMake framework

0fbf3d2

illwieckz force-pushed the illwieckz/cmake branch from 586202a to fdff956 Compare October 5, 2026 23:43

illwieckz changed the base branch from master to illwieckz/mingw-2 October 5, 2026 23:43

illwieckz added 2 commits October 6, 2026 01:50

trusted: add ifdef NACL_X86_64_ZERO_BASED_SANDBOX

6ac7627

illwieckz force-pushed the illwieckz/cmake branch from fdff956 to c6430fd Compare October 5, 2026 23:50

Conversation

illwieckz commented Jun 21, 2026

Uh oh!

slipher left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

illwieckz Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

illwieckz commented Oct 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

illwieckz Oct 5, 2026 •

edited

Loading