Netcode cleanup and improved verbosity#1976
Open
slipher wants to merge 5 commits into
Open
Conversation
Also remove commented-out junk.
The bug didn't have any consequences because only full bytes are permitted in OOB messages; the bit counter is not really needed.
When using MSG_WriteByte or MSG_WriteShort, warn if the value is outside of the allowed range. MSG_WriteShort is split up into MSG_WriteShort (signed) and MSG_WriteUShort because we use both signed and unsigned 16-bit values.
- Simplify MSG_WriteBits algorithm - Avoid pointless string copy in MSG_Write(Big)String
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up unused functions and simplify some implementations of netcode functions. Print a warning when passing an out-of-range value to
MSG_WriteByteorMSG_WriteShort/My ultimate goal is to enable warnings whenever a
playerState_torentityState_tfield is outside of the range specified in the netcode table. I have an implementation, but it's not ready to merge yet since Unvanquished has various fields that trigger warnings. For example there are flags fields where 16 bits are transmitted, but additional upper bits are also used for sgame-only flags.