feat (3320): add Documentation link to Admin Sidebar - #5327
feat (3320): add Documentation link to Admin Sidebar#5327guillermo-escire wants to merge 6 commits into
Conversation
|
Hi @tdonohue , as discussed, the previous PR #5077 was affected by the PolinRider malware on Jorge's account. I have cleaned up all the changes and created a new PR from a clean repository. The new PR also addresses all the feedback from @MMilosz (visible: true for all admin sidebar users, external link icon, and configurable documentation URL). Please review the new PR instead. Sorry for the inconvenience. |
|
Hi @guillermo-escire, |
|
Hi @guillermo-escire, |
| EditCMSMetadataMenuProvider, | ||
| EditUserAgreementMenuProvider, |
There was a problem hiding this comment.
I haven't tested this PR, but I noticed this PR removed these 2 providers, could you please restore them?
dc0721c to
b1be908
Compare
References
Fixes #3320
Description
This PR adds a "Documentation" link to the Admin Sidebar menu. The link URL is automatically generated based on the DSpace backend version, and can also be customized via configuration.
Instructions for Reviewers
List of changes in this PR:
How to test:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.