[tailctl] Require macOS - #4
Merged
Merged
Conversation
tailctl is pure Python, so the formula happily built and installed on x86_64_linux in CI — for a tool whose `init` discovers accounts through Tailscale.app and whose docs assume Homebrew macOS prefixes. macOS is the only platform upstream claims (see the PyPI classifiers) or tests. Blocking the install is better than shipping a path nobody has ever run. Drop this line if Linux support ever becomes real and tested. Solves: installable-but-nonfunctional Linux builds Tests: install --build-from-source, brew test, audit --strict --online, and style all clean on macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formula gate probe surfaced this:
brew test-botbuilt and installed tailctl cleanly onx86_64_linux, bottle and all.That works only because tailctl is pure Python.
initandbootstrapdiscover accounts through/Applications/Tailscale.app, the README assumes Homebrew macOS prefixes, and the PyPI classifiers listOperating System :: MacOS :: MacOS Xand nothing else. Linux is untested, undocumented, and unclaimed.depends_on :macosmakes the formula agree with what the package already says about itself. One line, trivially reversible the day Linux support becomes real.Note this means the ubuntu runner will now skip the formula — the two macOS runners are the ones that matter here.
Verification
brew install --build-from-source,brew test,brew audit --strict --online, andbrew styleall clean locally. This PR touches the formula, so CI should select it (testing_formulae drycodeworks/tap/tailctl) rather than reporting green on(none).