Split Water Data adapters by collection family - #351
Draft
thodson-usgs wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency
This PR is stacked on and must merge after #350. Its branch starts at #350 head
966bb618; while #350 remains open, this PR intentionally includes those commits in its comparison withmain.Summary
dataretrieval.waterdata.apias a logic-free compatibility facade with unchanged public imports, signatures, function identity, metadata, warnings, exceptions, and deprecationsCompatibility
The contract tests freeze all 19 Water Data facade exports and exact signatures. They also verify package/facade object identity, legacy
__module__, Samples private compatibility names, and the facadeget_ogc_datapatch target.Validation
ruff checkandruff formatmypy: 50 source files cleancoverage run -m pytest tests/: 663 passed, 97% coveragemake html: succeeded (4 pre-existing warnings)ogc.context, andogc.schemaimportable outside the checkout; facade identity and module metadata preserved