refactor(ogc): stabilize module boundaries - #348
Merged
thodson-usgs merged 1 commit intoAug 3, 2026
Conversation
thodson-usgs
force-pushed
the
refactor/phase-1-ogc-boundaries
branch
from
August 2, 2026 19:32
273b2b6 to
d77f388
Compare
thodson-usgs
marked this pull request as ready for review
August 3, 2026 14:40
Separate OGC policy and request construction from orchestration, expose a small service-adapter facade, and remove the shaping-to-engine dependency cycle. Narrow Water Data and NGWMN dependencies, preserve legacy private compatibility paths, and scope API credentials to the authorized host across redirects. Add executable architecture and security guardrails plus current-state documentation.
thodson-usgs
force-pushed
the
refactor/phase-1-ogc-boundaries
branch
from
August 3, 2026 14:43
29b8b6c to
69a9d1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
This branch is based directly on
mainat44f2aeecand contains one commit:69a9d1bd—refactor(ogc): stabilize module boundariesSummary
OgcDialectand endpoint defaults into the low-levelogc.policyleafogc.requestsogc.engine, with a frozen compatibility surface for previous private importswaterdata.utilsas a bulk re-export of private OGC helpersAPI_USGS_PATtoapi.waterdata.usgs.gov, including stripping it before sync or async cross-host redirectsWhy
The architecture baseline identified private cross-package contracts, a logical
ogc.engine/ogc.shapingcycle, and generic OGC requests that could receiveWater Data credentials without considering the destination host. This change
stabilizes those existing boundaries without introducing the separate
API-neutral transport layer in downstream PR #350.
Compatibility
Public service imports, function signatures, return shapes, metadata,
deprecations, pagination, chunking, retry, and resume behavior are unchanged.
Previous underscore-prefixed OGC paths remain available where compatibility is
required, and an architecture fitness function prevents that legacy surface
from expanding.
Validation
ogc.policyandogc.requestsScope
This PR stabilizes existing OGC boundaries. API-neutral transport extraction
and migration of Water Use away from private OGC pagination are isolated in
stacked draft PR #350.