Skip to content

[CU-86baqy91f] Remove deprecated X-Admin-Only-Action header (send only X-Global-Namespace) #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpanik merged 1 commit into from
Jul 20, 2026
Merged

[CU-86baqy91f] Remove deprecated X-Admin-Only-Action header (send only X-Global-Namespace) #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dnastack/client/workbench/workflow/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from dnastack.common.tracing import Span
from dnastack.http.session import JsonPatch, HttpSession, ClientError

_GLOBAL_NAMESPACE_HEADERS = {'X-Global-Namespace': 'true', 'X-Admin-Only-Action': 'true'}
_GLOBAL_NAMESPACE_HEADERS = {'X-Global-Namespace': 'true'}


class WorkflowDefaultsListResultLoader(WorkbenchResultLoader):
Expand Down
2 changes: 0 additions & 2 deletions tests/unit/client/workbench/workflow/test_workflow_client_admin_header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,10 @@ class TestAdminOnlyActionHeader:
def _assert_header_present(self, call_kwargs):
headers = call_kwargs.get('headers', {})
assert headers.get('X-Global-Namespace') == 'true', f"Expected X-Global-Namespace=true, got: {headers}"
assert headers.get('X-Admin-Only-Action') == 'true', f"Expected X-Admin-Only-Action=true, got: {headers}"

def _assert_header_absent(self, call_kwargs):
headers = call_kwargs.get('headers', {})
assert 'X-Global-Namespace' not in headers, f"Unexpected X-Global-Namespace header in: {headers}"
assert 'X-Admin-Only-Action' not in headers, f"Unexpected X-Admin-Only-Action header in: {headers}"

def test_create_workflow_sends_admin_header(self):
client = _create_workflow_client()
Expand Down
Loading