fix: default documentation URL to diracx.diracgrid.org - #507
Merged
Merged
Conversation
Contributor
|
There is a failing test because of the following change I introduced: https://github.com/DIRACGrid/diracx/blob/5b4b7ed5760ca6af9b53ee1e3776da98e9404be9/diracx-routers/src/diracx/routers/jobs/submission.py#L54 I will fix it (unless you are willing to do it and can do so by the end of the week, otherwise I fix it next week 🙂 ) |
Contributor
Author
|
Hi, thanks for the pointer, it should be fixed in #508. |
Old diracx.io domain was unused. Move the default up to Dashboard's props (visible in Storybook), drop the now-dead fallback in DashboardDrawer, and enable the Storybook control.
aldbr
force-pushed
the
fix/documentation-url-default
branch
from
September 23, 2026 14:01
3b6792c to
13bf04f
Compare
aldbr
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default fallback url for documentation was still set to
diracx.io.Move the default up to Dashboard's props (visible in Storybook), drop the now-dead fallback in DashboardDrawer, and enable the Storybook control.