[CP] Fix iOS Touch popover gesture completion#912
Merged
Conversation
Vetle444
changed the title
Vetle444
force-pushed
the
vefi/bugfix-1844-touch-popover-60.2.x
branch
from
5e0e60a to
bdaf093
Compare
eirinsvi
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Cherry-pick of #911 to
patch/60.2.x.Fixes an iOS gesture state issue where opening a popover or context menu from
Touch.Commandcould leave scrolling and swipe-back gestures broken after the overlay was dismissed.The root cause was that the custom
TouchEffectTapGestureRecognizerexecuted the tap command directly fromTouchesEndedwithout first completing/failing its own UIKit recognizer state. If that command opened a popover, UIKit could enter the presentation/dismissal flow while the Touch recognizer was still part of the active touch sequence.This change makes the Touch recognizer explicitly set
Ended,Failed, orCancelled, and defers command execution to the next main-thread turn so UIKit gets a clean gesture boundary before the popover/context menu opens.The previous fix in this patch line remains in place where it is still useful for preventing taps behind open overlays, but its broad pan/simultaneous-recognition workaround was only a band-aid and did not fix the fundamental recognizer lifecycle issue. This PR replaces that part with the root-cause fix.
Todos