feat/df-1063: Passes selected language to downstream systems#1248
Merged
Conversation
davidjamesstone
approved these changes
Jul 24, 2026
alexluckett
reviewed
Jul 24, 2026
| }, | ||
| query: {}, | ||
| app: { model } | ||
| } as unknown as FormRequest) |
| _emailAddress: string, | ||
| items: DetailItem[], | ||
| submitResponse: SubmitResponsePayload, | ||
| _language: string, |
Contributor
There was a problem hiding this comment.
rather than adding this as a parameter, you could make use of the request.server property? getPluginOptions(request.server).getLanguage(request)
Would have saved your sonar issue 😀
davidjamesstone
approved these changes
Jul 24, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes selected language to downstream systems
Translates the Alpha/Beta banner if necessary
Needs a plugin bump when DEFRA/forms-engine-plugin#445 is merged