Skip to content

feat/df-1063: Removed language param as can be derived from request #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbarnsley10 merged 1 commit into from
Jul 24, 2026
Merged

feat/df-1063: Removed language param as can be derived from request #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/server/plugins/engine/pageControllers/SummaryPageController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,6 @@ export async function submitForm(
emailAddress,
items,
submitResponse,
translator.language,
formMetadata
)
} catch (err) {
Expand Down
17 changes: 5 additions & 12 deletions src/server/plugins/engine/services/notifyService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { type FormMetadata } from '@defra/forms-model'

import { EN_GB } from '~/src/server/constants.js'
import { escapeMarkdown } from '~/src/server/plugins/engine/components/helpers/index.js'
import { checkFormStatus } from '~/src/server/plugins/engine/helpers.js'
import { type FormModel } from '~/src/server/plugins/engine/models/index.js'
Expand Down Expand Up @@ -73,8 +72,7 @@ describe('notifyService', () => {
model,
'test@defra.gov.uk',
items,
submitResponse,
EN_GB
submitResponse
)

expect(sendNotificationMock).toHaveBeenCalledWith(
Expand Down Expand Up @@ -110,8 +108,7 @@ describe('notifyService', () => {
model,
'test@defra.gov.uk',
items,
submitResponse,
EN_GB
submitResponse
)

expect(sendNotificationMock).toHaveBeenCalledWith(
Expand Down Expand Up @@ -149,8 +146,7 @@ describe('notifyService', () => {
model,
'test@defra.gov.uk',
items,
submitResponse,
EN_GB
submitResponse
)

expect(sendNotificationMock).toHaveBeenCalledWith(
Expand Down Expand Up @@ -197,7 +193,6 @@ describe('notifyService', () => {
'test@defra.gov.uk',
items,
submitResponse,
EN_GB,
formMetadata
)

Expand Down Expand Up @@ -249,8 +244,7 @@ describe('notifyService', () => {
model,
'test@defra.gov.uk',
items,
submitResponse,
EN_GB
submitResponse
)

expect(getFormatter).toHaveBeenCalledWith('machine', '2')
Expand Down Expand Up @@ -302,8 +296,7 @@ describe('notifyService', () => {
model,
'test@defra.gov.uk',
items,
submitResponse,
EN_GB
submitResponse
)
).rejects.toThrow('Notification service unavailable')

Expand Down
1 change: 0 additions & 1 deletion src/server/plugins/engine/services/notifyService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export async function submit(
emailAddress: string,
items: DetailItem[],
submitResponse: SubmitResponsePayload,
_language: string,
formMetadata?: FormMetadata
) {
if (!templateId) {
Expand Down
1 change: 0 additions & 1 deletion src/server/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ export interface OutputService {
emailAddress: string,
items: DetailItem[],
submitResponse: SubmitResponsePayload,
language: string,
formMetadata?: FormMetadata
) => Promise<void>
}
Loading