Skip to content

feat/df-1225: Translates error description if applicable #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbarnsley10 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat/df-1225: Translates error description if applicable #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a32981
Translates error description if applicable
jbarnsley10 Jul 21, 2026
f74f74a
Merge branch 'main' into feat/df-1225-error-description
jbarnsley10 Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/server/plugins/engine/components/ComponentCollection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,12 +308,11 @@ export class ComponentCollection {
labelOverrides[subField.name] = patchedSchema
}
} else {
const fieldAsComponentDef = field as unknown as ComponentDef
const translatedLabel =
translator.tComponent(
field as unknown as ComponentDef,
'shortDescription'
) ||
translator.tComponent(field as unknown as ComponentDef, 'title')
translator.tComponent(fieldAsComponentDef, 'errorDescription') ||
translator.tComponent(fieldAsComponentDef, 'shortDescription') ||
translator.tComponent(fieldAsComponentDef, 'title')
const messagesOverride =
field.getValidationMessagesOverride(translator)
let patchedSchema = field.formSchema
Expand Down
1 change: 1 addition & 0 deletions src/server/plugins/engine/i18n/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export type FormDefinitionTranslations = Record<
hint: string
content: string
shortDescription: string
errorDescription: string
paymentDescription: string
}>
>
Expand Down
Loading