Repository navigation
Sample snapshot cursor position after desktop and tree collection - #509
Merged
Jeomon merged 1 commit intoOct 26, 2026
Merged
Conversation
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop.get_state()reads the cursor before querying virtual desktops and walking the UI tree. If the pointer moves during that work,ScreenshotandSnapshotreturn the earlier position. An annotated capture also marks the earlier position, and a region capture can incorrectly include or omit the cursor when it crosses the region boundary.Move the cursor read after desktop collection, tree traversal and region filtering, just before screenshot capture. The response and annotation share that reading, with region clipping applied to the new position.
Related to #505. This reproduces stale coordinates caused by movement during collection; I have not reproduced the report's exact external
SetCursorPos/HTTP sequence.GetCursorPosis already called on every request, so this change addresses sampling order rather than a cross-request cache. It does not make cursor sampling and image capture atomic.Validation on Windows / Python 3.14.8:
92a649band pass with this change. They simulate movement during virtual-desktop queries or UI-tree traversal and cover clean/annotated screenshots, visual/text snapshots, and entry into or exit from a capture region. Windows input and screen capture are mocked; the tests do not move the real pointer.NO_PROXY=*and a workspace-local--basetempwhose parent exists.git diff --checkpasses. The service module has a pre-existing formatting difference outside this change.