#1178 Support for route parameters in WebSocket onaccept handlers - #1224
Open
jwolak wants to merge 1 commit into
Open
#1178 Support for route parameters in WebSocket onaccept handlers#1224jwolak wants to merge 1 commit into
jwolak wants to merge 1 commit into
Conversation
…route parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers to #1178
Add support parameterized routes like:
/ws/<int>/ws/<string>/ws/<path>and pass the parsed values directly into the
onacceptcallback, e.g.:This makes WebSocket route logic consistent with the rest of Crow’s routing system and enables request-specific validation or connection setup based on URL parameters.
The change also supports
bool-returning onaccept handlers, where returning false rejects the upgrade with a 400 response, and includes unit tests covering int, uint, double, string, path, and rejection cases.