feat(app): allow setting static directory at runtime (#414) - #1222
Open
soniafergusonship wants to merge 2 commits into
Open
feat(app): allow setting static directory at runtime (#414)#1222soniafergusonship wants to merge 2 commits into
soniafergusonship wants to merge 2 commits into
Conversation
Signed-off-by: soniafergusonship <soniafergusonship@users.noreply.github.com>
Signed-off-by: soniafergusonship <soniafergusonship@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a runtime
Crow::static_directory()setter/getter so the implicit static file root can be chosen without a compile-timeCROW_STATIC_DIRECTORYmacro (#414).CROW_STATIC_DIRECTORY("static/")run()/run_async()(path is captured when static routes are registered)CROW_STATIC_ENDPOINTis unchangeddocs/guides/static.mdTest plan
app.static_directory("alt/")serves files fromalt/at the default static endpointCROW_STATIC_DIRECTORYCROW_STATIC_DIRECTORYstill sets the default when no runtime call is madeCloses #414