Repository navigation
Add btn-theme default style, gray active item, menu shadow, and dark-mode btn-dark border - #19
Merged
Merged
Conversation
…d a dark-mode border for btn-dark
…g light in dark mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the default look match a stock Bootstrap 5.3 select in light and dark modes.
btn-themestyle (new, now the defaultstyle). Renders light in light mode and dark in dark mode by following Bootstrap's CSS variables. This is the themed behavior the defaultbtn-lighthad before.btn-lightis stock again. It stays light in dark mode. Usebtn-theme(or omitstyle) to follow the color mode.btn-darkborder in dark mode. The toggle previously blended into the page because its border matched its background; it now uses--bs-border-color, like a native dark-mode input.--bs-secondary-bg(hover--bs-tertiary-bg) instead of the primary blue. Override--bs-dropdown-link-active-bg/--bs-dropdown-link-active-coloron.bootstrap-select .dropdown-menuto restore the primary highlight.--bs-box-shadow.The Select all / Deselect all buttons follow
btn-themeas well.Breaking-ish
Anyone relying on
data-style="btn-light"to follow dark mode should switch tobtn-theme(or dropdata-style). Default users see no change except the gray highlight and shadow.Test plan
tests/e2e/theme-styles.spec.jscovers the default style,btn-themein both modes,btn-lightin dark mode,btn-darkborder, shadow and the gray active item.npm run lintclean.Docs (
options.mdx,examples.mdx) and the changelog are updated.🤖 Generated with Claude Code