Repository navigation
Add optional gzip request compression - #347
Open
turtledreams wants to merge 2 commits into
Open
turtledreams wants to merge 2 commits into
turtledreams wants to merge 2 commits into
Conversation
CI report
Code Coverage: Coverage, Line coverage 90.4% (sdk-java), 70.5% (sdk-java-ui)
Files changed by this pull request
Least covered classes (10 shown)
Dependency Security Scan: Dependency scan, No blocking vulnerabilityScanned 25 resolved dependencies, failing on HIGH and above. Java Gradle Build and Test: Unit tests, 806 passed, 0 failed, 0 skippedThe check run lists every test and each failure. Public API changes: Public API, 0 removed or changed, 2 addedAdded: 2. Check that each one is meant to be public. Static analysis, No new findingsSpotBugs: 147 findings
First 50 findings
New compared with the base branch: 0No finding that the base branch does not have. For 9539040, updated 2026-11-18 04:31 UTC. Each check's run page has its full log. |
Dependency security scanScanned 25 resolved dependencies, failing on HIGH and above. Result: passed |
Public API changesAdded: 2. Check that each one is meant to be public. |
Code coverage
Files changed by this pull request
Least covered classes (10 shown)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional compression of request bodies.
enableRequestCompression(), off by default. It does not apply in backend mode, which does not use the SDK behavior settings.gzip=1. A server that reads compressed bodies answers with"gzip": truenext toc. The SDK keeps that answer in memory and never stores it.GZIPOutputStreamand sent to the endpoint withcontent_encoding=gzipas its only query. A body over 1 MB goes plain, because the server refuses a larger compressed body. The Content-Type staysapplication/x-www-form-urlencodedand no Content-Encoding header is set. A body goes compressed only when it gets smaller."gzip": true, or when the SDK starts again. Network errors and timeouts do not stop it."gzip": true, so it keeps getting plain requests.Config.enableRequestCompression()and two default methods of the configuration provider.gzip=1, plain bodies/i?content_encoding=gzipas gzip, decodes to the plain body and carries the plain body's checksumgzipkey gets plain bodiesgzipturns compression on againgzipanswer is not stored with the behavior settingsTests:
RequestCompressionTests(17 tests);ModuleConfigurationTestslistsgzipamong the top-level answer keys. The full suite (806 tests) passes; the public API record was regenerated with metalava.