Repository navigation
test(sarif): check the log root and runs[0] are objects before using them - #34
Merged
Merged
Conversation
…them The Run helper dereferenced the parsed log and its first run without checking they were objects, so a log of the wrong shape crashed sarif_unit instead of failing a check. RunOf now returns an empty run for such a log, and a test feeds it an array and a non-object run. Closes #33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33.
Change
unittests/sarif_test.cpp: the parsing of theRunhelper moves toRunOf(text), which checks that the log root andruns[0]are objects and returns an empty run otherwise.Run(findings)calls it on the writer's output, so the existing checks are unchanged.Test first
MalformedLogHasNoRunfeedsRunOfa top-level array ([]) and a non-object run ({"runs": [1]}):sarif_unit (SEGFAULT);sarif_test: all checks passed.ctest --test-dir build: 17/17 passed;scripts/format-check.sh: clean.