Repository navigation
Flow nonlocal writes back to the enclosing function - #84
Merged
Merged
Conversation
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last documented approximation of the analysis, item of #71: a
nonlocalwrite made by a nested function now flows back to the enclosing function.test: define nonlocal writes flowing back to the caller), implementation follows.nonlocalalso emits aset_nonlocaleffect, kept through SSA likeset_global. After a direct call to a nested function it defined, the enclosing function emits onenonlocal_resultper name that function declaresnonlocaland stores it back into its own variable, so SSA sees the rebinding.FunctionSummary.nonlocal_writesrecords, per written name, the parameters and external results the nested function stores into it. The dependence and taint engines evaluatenonlocal_resultfrom the callee's summary and the call's arguments, captured values included, exactly as they evaluate a call's return.nonlocal_writes; the format is bumped to 3 so older entries are recomputed.Part of #71.