Repository navigation
Report credentials in test code and template files at low confidence - #82
Merged
Merged
Conversation
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third item of #71: credentials in test code and template files are reported at low confidence.
test: define the confidence of credentials in tests and examples), implementation follows.plugins/secrets.py:credential_contextclassifies a path astest(atests,test,testing,fixturesor__tests__directory, atest_*.py,*_test.pyorconftest.pyfile),example(.example,.sample,.dist,.tplsuffixes) or neither. Ahardcoded-credentialthere is reported at low confidence with the context in its metadata; elsewhere it stays medium. Provider-formathardcoded-secretfindings keep their confidence everywhere, since a real key in a test is still a key..env.example; a consumer sorting or filtering on confidence now sees the three that matter first. Snapshots record rule and location only, so they are unchanged.Part of #71.